[MGNLMULTPA-55] Provide generic keys for dialogs Created: 01/Dec/23  Updated: 13/Dec/23  Resolved: 07/Dec/23

Status: Closed
Project: Multiple Pages Apps
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.0

Type: Task Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Chuong Doan Huy
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 1d 5h
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: Multiple Pages App LD
Sprint: DevX 52
Story Points: 2
Team: DeveloperX
Work Started:

 Description   

There are some dialog labels that say "Pages", but none should by default. 

Consider the case that develoer creaates another app called "banners", then it is confusing if when they click the "Add Item" action - they get a dialog that saays "Add Page".

Known cases:

Browser view: Add item

Browser view: Rename Item

Technical notes

I think these keys come from here: 

https://git.magnolia-cms.com/projects/MODULES/repos/pages/browse/magnolia-pages-app/src/main/resources/pages-app/i18n/pages-app-browser_en.properties

However - solving this seems a little tricky - because the key is identified by the name of the module "pages-app". So how can we have a label that says "Add page" when used in the pages app - but "Add item" when used in a custom pages app? 

I don't think its possible to set a key based on which App is currently live.

I think a solution could be to create NEW dialogs "createItem" and renameItem" in the multiple-paages-apps-editor module  and have the custom pages app point to those dialogs in its "action" definitions.

 

It might be easy to create these dialogs using definition inheritance:

https://docs.magnolia-cms.com/product-docs/6.2/Developing/Reusing-configuration/YAML-inherit-and-include.html#_yaml_inherit


Generated at Mon Feb 12 10:21:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.