[MGNLNEWSLETTER-26] Newsletter subscription logic doesn't work with current forms module Created: 10/Oct/11  Updated: 26/Jun/12  Resolved: 20/Feb/12

Status: Closed
Project: Newsletter (closed)
Component/s: stk integration
Affects Version/s: 1.0.2
Fix Version/s: 1.0.2

Type: Bug Priority: Neutral
Reporter: Sean McMains Assignee: Samuel Schmitt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
duplicate
duplicates MGNLNEWSLETTER-25 Upgrade to Form 1.2 Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

When using v1.0.2 of the Newsletter STK module, we get an error when setting the form processor:

2011-09-07 12:03:13,905 WARN  gnolia.content2bean.impl.Content2BeanProcessorImpl: can't resolve class for node /modules/newsletter-stk/paragraphs/stkNewsletterSubscribe/formProcessors/subscribeNewsletter
java.lang.NoClassDefFoundError: info/magnolia/module/form/processing/FormProcessor
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)

And the subscription doesn't work.



 Comments   
Comment by Sean McMains [ 10/Oct/11 ]

Fix included as part of WEBSITE-423.

Comment by Magnolia International [ 10/Oct/11 ]

It looks like the error handling in both processor classes behaves differently (error message "lost" when unsubscribing ?). If they have to behave the same way, I'd advise extracting that logic in a common superclass (seems to be a lot of duplicated code?) - if not, perhaps a clarifying inline comment would help.

Comment by Magnolia International [ 10/Oct/11 ]

MGNLNEWSLETTER-25 also covers this issue.
Another thing to change is that (perhaps this wasn't the case with previous version of the form api), one can use the parameters map in the process() method

Comment by Samuel Schmitt [ 20/Feb/12 ]

class set on info.magnolia.newsletter.form.SubscribeFormProcessor

Comment by Samuel Schmitt [ 20/Feb/12 ]

info.magnolia.newsletter.form.SubscribeFormProcessor

Generated at Mon Feb 12 10:22:07 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.