[MGNLNEWSLETTER-42] Refactor to use campaignmonitor monitor API v3 Created: 13/Nov/12 Updated: 27/Mar/13 Resolved: 25/Mar/13 |
|
| Status: | Closed |
| Project: | Newsletter (closed) |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.3 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Tomáš Gregovský | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Date of First Response: | |||||
| Description |
|
The Campaign Monitor now using API v3, but our magnolia-module-newsletter-campaign-monitor still using old API v2. We should move to new API. API v3: http://www.campaignmonitor.com/api/ |
| Comments |
| Comment by Magnolia International [ 01/Mar/13 ] |
|
Some review notes:
Side note: you seem to have introduce windows-line endings in some of the files. Normally, this doesn't happen with Git, unless you transfer the file between machines using different line-ending with another mechanism than Git itself. I think I fixed it, but be careful. If you need to work on several machines on the same project, you can always push between your machines without pushing to the central server, or create a temporary branch |
| Comment by Magnolia International [ 01/Mar/13 ] |
|
And another note regarding the test: why do you use @BeforeClass and static members ? I don't really see any benefit here; if there is, it should be noted/commented. |
| Comment by Milan Divilek [ 25/Mar/13 ] |
We have two campaign manager service implementations - HttpSubscriber and JsonSubscriber. That's why we have two newsletter-bundles. magnolia-module-newsletter-bundle-1.3-SNAPSHOT contains CM module, but without its dependencies - because this bundle is intended to be used with HttpSubscriber which doesn't need createsend-java library. |
| Comment by Milan Divilek [ 27/Mar/13 ] |
|
https://git.magnolia-cms.com/gitweb/?p=enterprise/newsletter.git;a=commit;h=9cbb156d1d9bfb0029a29588258244cd7a72889f |