[MGNLOBS-39] Remove uses of the Content API Created: 14/Jul/17 Updated: 05/Oct/17 Resolved: 01/Sep/17 |
|
| Status: | Closed |
| Project: | Observation |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.1 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Michael Mühlebach | Assignee: | Evzen Fochr |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tech-debt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: | |
| Epic Link: | Remove Content API |
| Sprint: | Kromeriz 109, Kromeriz 110, Kromeriz 111 |
| Story Points: | 3 |
| Description |
|
see https://wiki.magnolia-cms.com/pages/viewpage.action?pageId=136852051 for further detail. |
| Comments |
| Comment by Evzen Fochr [ 16/Aug/17 ] |
|
I we still want to be able to use SynchEventListener in ObservationModule, we need to move this class from info.magnolia.module.observation.util.ObservationUtil to magnolia-core/src/main/java/info/magnolia/observation |
| Comment by Evzen Fochr [ 17/Aug/17 ] |
|
SynchEventListener was moved to ObservationModule as private inner class. |
| Comment by Evzen Fochr [ 28/Aug/17 ] |
|
Need to raise version on release/5.5 branch to 2.1 |
| Comment by Mikaël Geljić [ 28/Aug/17 ] |
|
Why was magnolia dependency upgraded to 5.4.6 only? (hence without Java 8) |
| Comment by Roman Kovařík [ 29/Aug/17 ] |
|
| Comment by Mikaël Geljić [ 29/Aug/17 ] |
|
Yeah, that's what I thought. In theory, it could remain compatible w/ 5.4.x, but since we are making a new major of observation, there is no strong need to. In particular, we don't want to introduce a new major that does not compile w/ Java 8, so this calls for making this depend upon magnolia 5.5 minimum (I don't mind if you want to choose 5.6). We will not upgrade existing 5.4 and 5.5 bundles with the new observation version. The overall Content API cleanup is targeted at 5.6 only. The ObservationUtil replacement is just nice to keep code tidy without deprecations, but that's not a main driver imo. |
| Comment by Roman Kovařík [ 29/Aug/17 ] |
Also ObservationUtil suffers from memory leaks, that's why the dependency was upgraded to 5.4.6 only I suppose (even if not bundled with 5.4/5.5, you can use it). |