[MGNLPCK-33] binary data are not checked for updates Created: 01/Dec/09  Updated: 15/Sep/15  Resolved: 03/Dec/09

Status: Closed
Project: Packager (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 4.0.2

Type: Bug Priority: Major
Reporter: Jan Haderka Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Currently all of the jcr:xxx properties are ignored by packager during updates. This leads to missing the updates of binary data when such are modified. Binary data could be updated only by deleting the node and then creating it again.



 Comments   
Comment by Ralf Hirning [ 02/Dec/09 ]

As much as I see the problem is the method getNodeDataCollection which excludes the jcr:xxx nodes. Whenever we use getNodeDataCollection we should include jcr:data. This must be done in JcrPackageNode.getNodeDataCollection(...) and we should call this method in PackageNodeData.store(...) instead of MagnoliaPackageNode.getNodeDataCollection(...).

Comment by Jan Haderka [ 02/Dec/09 ]

I'm not very keen on including the jcr:data in nodeDataCollection. It is one thing to duplicate values for text or numeric nodes and it is another to duplicate binary data where the size is much bigger.
As for the renaming, yes the Packager should be refactored and have its code cleaned up, but that is a matter for a major release not for fixing this bug.

Comment by Jan Haderka [ 03/Dec/09 ]

The commit of the code changes was not actually made for 4.0.1

Comment by Michael Mühlebach [ 15/Sep/15 ]

This ticket was closed because former resolved tickets are deemed to be closed now. If this assumption is untrue in this particular case please feel free to reopen the ticket again.

Generated at Mon Feb 12 10:25:21 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.