[MGNLPCK-34] Code refactoring Created: 02/Dec/09  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Packager (closed)
Component/s: None
Affects Version/s: 4.0
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: Jan Haderka Assignee: Ralf Hirning
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

There are few things that are necessary to keep the code maintainable:

  • at various places exceptions are used to transfer the result of methods (e.g. JcrPackagedNode.checkForChange()
  • the properties are duplicated in the packaged nodes (all properties are available in the exported xml as well as in the <NodeDataList> subelements. This is unnecessary and blows up the size and memory footprint of the packager.
  • the packaged nodes are processed in-memory most of the time which blows when package contains big media files.
  • jar files are opened and parsed at various places and processed multiple times in consequent operations which makes whole processing slower (e.g. the change list is generated once when the dialog is open and second time when user hits the "install package" button from the very same dialog.
  • usage of Vector all around the place should be unnecessary.
  • module would benefit moving to Java 5 baseline and from introducing generics.


 Comments   
Comment by Ralf Hirning [ 02/Dec/09 ]

Thanks Jan for this summary. I will work on that and I would like to sync my approach with you then

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 10:25:21 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.