[MGNLPCK-51] Packager doesn't work in Magnolia 4.4.10-jr24 Created: 06/Mar/13  Updated: 29/Mar/13  Resolved: 20/Mar/13

Status: Closed
Project: Packager (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 4.0.8

Type: Bug Priority: Major
Reporter: Bence Vass Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File packager1.jpg     JPEG File packager2.jpg    
Issue Links:
causality
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

The packager module doesn't seem to work in magnolia 4.4.10-jr24

installed the enterprise bundle out of the box, and the packager is broken



 Comments   
Comment by Ralf Hirning [ 06/Mar/13 ]

It lokks as if there is a javascript problem. Maybe old javascript code is in use. Please clear the browser cache and retry. It works on Magnolia 4.5.7 ( see http://demo.magnolia-cms.com)

Comment by Bence Vass [ 07/Mar/13 ]

Yes it is definitely a javascript problem. We have several instances in use (4.4.6, 4.4.8, 4.5.7, 4.5.4) and the packager works in all. But in 4.4.10 (which we are migrating to on the 4.4.x instances) it does not. What you can see on the first screenshot (packager1.jpg) is just a display problem, but on the second screenshot you can see that the functionality is blocked (cannot create any ACLs).

I have tried clearing the browser cache, but it didn't change anything.

Comment by Bence Vass [ 13/Mar/13 ]

This seems to be a problem with the admininterface (4.4.10-jr24). Viewing/editing/adding ACLs (f.e. in the security module, or as seen in the screenshots in the packager) doesn't seem to work, there are javascript errors out of the box.

I've added this to the description and moved the issue.

Comment by Bence Vass [ 13/Mar/13 ]

This is the problematic code snippet (from DynamicTable.js of module-admininterface):

MgnlDynamicTable.prototype.render = function (update){
if(update==null)

{ update = false; }

if(update){ this.objects = this.getObjects(); }

// delte all
var table = document.getElementById(this.tableName);

//table.innerHTML=""; does not work with safari
for(i=table.rows.length-1; i>=0 ; i--){ table.deleteRow(i); }

for(i=0; i < this.objects.length; i++){
var row = table.insertRow(table.rows.length);
var cell = row.insertCell(0);
var obj = this.objects[i];
if (!(typeof obj == "undefined") && obj != null && obj.value.substring && obj.value != "") { obj.value = obj.value.replace(/&/g, '&').replace(/</g, '<').replace(/>/g, '>').replace(/"/g, '"').replace(/'/g, '''); }
cell.setAttribute("id", this.tableName + i + "Cell");
this.renderObject(cell, this.tableName + i, i, obj);
}
}



I have commented out the changed made in 4.4.10, then the ACL menu works again, but the display bugs are still there (see screenshot packager1.jpg):

MgnlDynamicTable.prototype.render = function (update){
if(update==null){ update = false; }

if(update)

{ this.objects = this.getObjects(); }

// delte all
var table = document.getElementById(this.tableName);

//table.innerHTML=""; does not work with safari
for(i=table.rows.length-1; i>=0 ; i--)

{ table.deleteRow(i); }

for(i=0; i < this.objects.length; i++){
var row = table.insertRow(table.rows.length);
var cell = row.insertCell(0);
// var obj = this.objects[i];
// if (!(typeof obj == "undefined") && obj != null && obj.value.substring && obj.value != "")

{ // obj.value = obj.value.replace(/&/g, '&').replace(/</g, '<').replace(/>/g, '>').replace(/"/g, '"').replace(/'/g, '''); // }

cell.setAttribute("id", this.tableName + i + "Cell");
// this.renderObject(cell, this.tableName + i, i, obj);
this.renderObject(cell, this.tableName + i, i, this.objects[i]);
}
}

Comment by Milan Divilek [ 13/Mar/13 ]

Hello Bence,

Edit: This seems to be a problem with the admininterface (4.4.10-jr24). Viewing/editing/adding ACLs (f.e. in the security module, or as seen in the screenshots in the packager) doesn't seem to work, there are javascript errors out of the box.

This is known bug(4.4.11 - MAGNOLIA-4898, 4.5.8 - MAGNOLIA-4895) and it will be fixed in 4.4.11.

The issue with packager it's another bug. I added it into 4.4.11 changelog.

Comment by Jan Haderka [ 18/Mar/13 ]

junit test?

Generated at Mon Feb 12 10:25:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.