[MGNLPER-180] RootPath is not used for findBar results Created: 26/Nov/21  Updated: 19/Dec/22  Resolved: 14/Dec/22

Status: Closed
Project: Periscope
Component/s: None
Affects Version/s: 1.2.6, 2.0.0
Fix Version/s: 2.0.0, 1.2.7

Type: Bug Priority: Neutral
Reporter: Antonio Tuor Assignee: Miguel Martinez
Resolution: Fixed Votes: 7
Labels: VN-Analysis, VN-Testing
Σ Remaining Estimate: 0d Remaining Estimate: 0d
Σ Time Spent: 1d 0.5h Time Spent: 1d 0.5h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: Zip Archive bookshelf.zip     Zip Archive course-app.zip     XML File custom-nodetype.xml     File persons-app-1.yaml     File persons-app.yaml    
Issue Links:
causality
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLPER-181 QA Sub-task Completed Thuy To  
Template:
Acceptance criteria:
[ ]* RootPath is used to create the link for find-bar results
[ ]* Item is highlighted when the find-bar result is clicked and the app is opened
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: AuthorX Support
Sprint: AuthX 23
Story Points: 2
Team: AuthorX
Work Started:

 Description   

Steps to reproduce

  1. Create an app and set a rootPath in the browser subapp datasource:
subApps:
  browser:
    datasource:
     rootPath: /myRootPath/
  1. Add an Item within the root path
  2. Close the app
  3. Search for the item in the find-bar
  4. Click on the result
  5. The right app is open, but the result is not preselected

 

Expected results

The url contains the full path of the node, to highlight/select it correctly:
http://localhost:8080/dev/.magnolia/admincentral#app:myApp:browser;/myRootPath/myItem:edit

Actual results

The url does not contain the rootPath, and therefore the node path is not absolute and the item is not preselected/highlighted:
http://localhost:8080/dev/.magnolia/admincentral#app:myApp:browser;myItem:edit

Workaround

Development notes



 Comments   
Comment by Anne Meister [ 25/Feb/22 ]

This issue has been open for a while and is a real problem for our client. Could we get this prioritized?

Comment by Anne Meister [ 01/Mar/22 ]

We now have another DX Core client with the same problem, which makes some content apps absolutely unusable for them as they can't use the search function. 

Please prioritize and fix this issue.

Comment by Jonathan Ayala [ 01/Mar/22 ]

When executing info.magnolia.admincentral.findbar.operation.InternalNavigationOperation.execute(InternalNavigationRequest) the value of request.path is relative to the configured root path of the app, i.e. it doesn't contain /myRootPath as explained in the description.

Comment by Rajeev Singh [ 24/May/22 ]

Hello, 

What's the priority and status of this issue? Thanks for your feedback

Regards, 

Comment by Rajeev Singh [ 30/May/22 ]

Hello, 
Any updates on the prioritization of this ticket? 
Regards, Rajeev

Comment by Rajeev Singh [ 08/Jun/22 ]

Any updates on the prioritization of this ticket? 

Comment by Rajeev Singh [ 14/Jun/22 ]

Hello, 

In which version this will be released?

@gabriele.piras@magnolia-cms.com

Regards

 

Comment by Jonathan Ayala [ 14/Jun/22 ]

Hello,

We are currently working on fixing this issue. Unfortunately, we don't have a specific date for the release yet but we'll let you know as soon as we have more information.

Regards.

Comment by Rajeev Singh [ 15/Jun/22 ]

Hello,

Since when team has been working on this topic? --> Affects Version/s:6.2.13, 6.2.17 (Created:26/Nov/21 10:32 AM)
New 6UI GUI was boosted with fancy search capabilities for the client and when we are really there nothing works!

PS: plz note that we are still running production with the 6.2.18-MAGNOLIA-8404 patch!

Comment by Laura Delnevo [ 17/Jun/22 ]

Hi rajeevsingh, I am Laura, PM for Author Experience. Thanks for your comments. As Jonathan mentioned, we are looking at the problem. I will be posting an update with the expected release as soon as we can.

Comment by Rajeev Singh [ 17/Jun/22 ]

Many thanks for the update, Laura. 
Regards, Rajeev 

Comment by Jonathan Ayala [ 06/Oct/22 ]

Hello rajeevsingh, atuor,

We are working on this issue and found the behaviour in the latest releases is slightly different when using the 6UI syntax. In order to make sure we cover all the scenarios we'd like you to provide us with the complete content app descriptor that is causing the issue in your instances. 

Regards,
Jonathan.

 

Comment by Michail Botas [ 07/Oct/22 ]

Hi Jonathan,

I will send you one of our custom apps today. I will simplify it having only 1 custom node type and I will provide you also customNodeTypes.xml to have also same custom node type.

 

Thanks,

Michail

Comment by Michail Botas [ 07/Oct/22 ]

Hi Jonathan,

 You can check persons-app.yaml and custom-nodetype.xml.
Let me know if it is ok for you.

Thanks,
Michail

Comment by Jonathan Ayala [ 19/Oct/22 ]

Thanks Michail,

The issue is reproducible with given app and node type.

Steps to reproduce

  1. Create node type. Here's a groovy script to do it:
    import info.magnolia.objectfactory.Components
    import info.magnolia.repository.RepositoryManager
    import javax.jcr.nodetype.NodeType
    
    app_repository     = "magnolia"
    app_workspace         = "persons"
    app_node_type         = "mgnl:person"
    
    // create workspace
    Components.getSingleton(RepositoryManager.class).createWorkspace(app_repository, app_workspace)
    // check we registered all right
    appSession = ctx.getJCRSession(app_workspace)
    // register node type
    nodeTypeManager = appSession.getWorkspace().getNodeTypeManager()
    type = NodeTypeTemplateUtil.createSimpleNodeType(nodeTypeManager, app_node_type, Arrays.asList(NodeType.NT_HIERARCHY_NODE, NodeType.MIX_REFERENCEABLE, NodeTypes.Created.NAME, NodeTypes.Activatable.NAME, NodeTypes.LastModified.NAME, NodeTypes.Renderable.NAME))
    nodeTypeManager.registerNodeType(type, true)
    appSession.save()
    // double check it registered all right
    nodeTypeManager.getNodeType(app_node_type)
  2. Add persons-app to a light module: use this adapted version  persons-app-1.yaml
  3. Create two items
  4. Search for them using the find bar and click over one result
Comment by Antonio Tuor [ 09/Nov/22 ]

Hi Jonathan,

Sorry for the late response, I was on vacation.
You can find attached the files for our app. Hope it works like this.

Best regards,
Antonio

course-app.zip

Comment by Laura Delnevo [ 19/Dec/22 ]

Hi, please note that the fix is being released on 6.2.27. Release notes will follow up shortly

Generated at Mon Feb 12 10:29:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.