[MGNLPER-55] Circular dependency between ui and periscope Created: 27/Sep/18  Updated: 12/Oct/18  Resolved: 05/Oct/18

Status: Closed
Project: Periscope
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Task Priority: Blocker
Reporter: Milan Divilek Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by DOCU-1693 Update Find bar documentation pages o... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Documentation update required:
Yes
Date of First Response:
Epic Link: 6.0 requisite
Sprint: Basel 157
Story Points: 5

 Description   

Periscope module has dependency to UI module - https://git.magnolia-cms.com/projects/MODULES/repos/periscope/browse/periscope-core/pom.xml#37

Ui module has dependency to periscope - https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-admincentral/pom.xml?at=refs%2Fheads%2Ffeature%2Fresurface#53

With circular dependency we are not able to release the modules. If you start with release of periscope than it will fail because UI is on SNAPSHOT, which you can't release because there's SNAPSHOT of periscope.

Only one module should have dependency to the other. Periscope should be just backgroud for search itself, so it should not have dependency to UI. All the UI actions should be part of findbar(UI).



 Comments   
Comment by Saimir Gasa [ 27/Sep/18 ]

mdivilek, could you please provide an Acceptance Criteria for this? What would it look like once complete? Please refer to Definition of Ready

 

Comment by Mikaël Geljić [ 27/Sep/18 ]

sgasa, DoR (which is yet to be signed off btw), only mandates ACs for USs. It should stay that way.

the issues to be presented should at least have an Acceptance Criteria (in case of a User Story), [...], and elaborate description on what needs to be accomplished.

We've got a pretty elaborate description I'd say.

Comment by Saimir Gasa [ 27/Sep/18 ]

mgeljic, true. I stand corrected. Just realised it's only a task.

Even though it's still not officially signed off, I would still recommend referring to the DoR for the time being simply because it's better than not having one.

Generated at Mon Feb 12 10:28:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.