[MGNLPER-75] Autogenerated JcrSearchResultSuppliers ignore app root path Created: 19/Nov/18 Updated: 24/Jan/19 Resolved: 04/Jan/19 |
|
| Status: | Closed |
| Project: | Periscope |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Adam Siska |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Epic Link: | Search relevance | ||||||||||||||||
| Sprint: | Foundation 1 | ||||||||||||||||
| Story Points: | 3 | ||||||||||||||||
| Description |
|
Business benefit: Build trust. Don't mislead the user. Show only relevant search results. Summary: If an app cannot display the found content then don't list the app in search results. E.g. a supplier for the Site app is created, searching whole config workspace. To reproduce:
Configuration, Cookies and Site apps are displayed in results. Only the Configuration app has access to the found target node appLauncherLayout. The other two apps can only access a very narrow subtree elsewhere in the config workspace. Since the user has no way of navigating to the appLauncherLayout node in the Cookies and Site apps the results are misleading. The same issue can be reproduced for categories/tours apps. Search in tours app should not return categories outside of tours app root path. Acceptance criteria:
|
| Comments |
| Comment by Roman Kovařík [ 19/Nov/18 ] |
| Comment by Roman Kovařík [ 04/Jan/19 ] |
|
QA: SELECT * FROM [nt:base] AS t WHERE ((lower(LOCALNAME()) LIKE '%%' AND ISDESCENDANTNODE('/modules/site/config/site')) AND (t.[jcr:primaryType] = 'mgnl:content' OR t.[jcr:primaryType] = 'mgnl:contentNode')) shouln't that be rather SELECT * FROM [nt:base] AS t WHERE ((lower(LOCALNAME()) LIKE '%%') AND (t.[jcr:primaryType] = 'mgnl:content' OR t.[jcr:primaryType] = 'mgnl:contentNode')) AND ISDESCENDANTNODE('/modules/site/config/site') ? |
| Comment by Roman Kovařík [ 04/Jan/19 ] |
|
nwm, I overlooked that the OR statement is in brackets.
Works in the latest EE So for the record: Content of the site app can't be searched as JCR search doesn't take (and can't easily) magnolia extending mechanism into account. The content can be still found by Configuration app search (if user has access to it). |