[MGNLPER-81] Path in the search result is different from the path that is actually opened Created: 05/Feb/19  Updated: 16/Apr/20  Resolved: 26/Feb/19

Status: Closed
Project: Periscope
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1

Type: Bug Priority: Neutral
Reporter: Martin Drápela Assignee: Andrei Ichimescu
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 2.5h
Original Estimate: Not Specified

Attachments: File SearchResultOpensIntoWrongPath_vokoscreen-2019-02-05_12-09-59.mkv     PNG File image-2019-02-05-12-13-59-750.png     PNG File path-excerpt vertical H.png    
Issue Links:
Cloners
is cloned by MGNLUI-5029 CLONE - Path in the search result is ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Documentation update required:
Yes
Date of First Response:
Epic Link: Periscope improvements
Sprint: Foundation 4, Foundation 5
Story Points: 3

 Description   

Experienced in EE 6.0.1 (Snapshot: 2019.02.05 08:53:58)

To reproduce:

1) Type pages app in the Find bar.

2) The system provides e.g. this among the results:

 

Look carefully at the path shown. It begins with /modules/pages/apps/.... 

3) So let's pick this result: Click at this search result item.

4) Magnolia opens the "activateRecursive" in the Config app, but with a wrong path:

/modules/translation-pages-integration/apps/pages-translation/subApps/browser/actions/activateRecursive

Clearly not the "activateRecursive" I wanted to go to.

(See also in the video attached.)

 

 



 Comments   
Comment by Andrei Ichimescu [ 08/Feb/19 ]

The issue is happening because the `activateRecursive` from the pages-translation extends the `activateRecursive` from the pages/apps.

So in the jcr there is a `translation-pages-integration/pages-translation/... activateRecursive` node that has a child 'extends' with a value that points to pages/app (/modules/pages/apps/pages/subApps/browser/actions/activateRecursive).

The displayed entries in the findBar results are generated based on a property called 'excerpt' and, for the affected entry, the value from the extends property is taken.

Questions:

   should the results in the findbar be generated based on path instead of property?

   should the excerpt property (the findbar results) be prefixed by 'extends' e.g.: extends /modules/pages/apps/pages/subApps/browser/actions/activateRecursive? (still it will not say it points to translation-pages)

   should we exclude the 'extends' childNode from the excerpt? (what to show and what to highlight in this case?)

   should we exclude the extended entries completely from the search index configuration?

Comment by Federico Grilli [ 08/Feb/19 ]

Another option could be in info.magnolia.periscope.search.jcr.ExcerptProvider#aggregatedContent to detect if property name is extends  and return its path instead iof its value, in our case  /modules/translation-pages-integration/apps/pages-translation/subApps/browser/actions/activateRecursive/extends
Well, I realized this is basically the first option but only in case of extends

Comment by Andrei Ichimescu [ 18/Feb/19 ]

New mock-up from avongunten

Comment by Anja von Gunten [ 18/Feb/19 ]

aichimescu For the highlighted characters lets use bold & black (also in the paths and excerpts).

Title: Roboto light, 14px, #232323

Path: Roboto medium, 12px, #232323, opacity 50%

Excerpt: Roboto light, 12px, #232323, opacity 50%

Character highlights for all: Roboto bold, #232323, opacity 100%

 

Comment by Christopher Zimmermann [ 18/Feb/19 ]

rkovarik That is fine with me. Assuming you mean the order in the backlog - its actually slutz that set the order.

Generated at Mon Feb 12 10:28:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.