Implement actions/commands for variant deletion/restoring (MGNLPN-118)

[MGNLPN-106] Add delete action which makes use of the VariantManager's delete method Created: 12/May/14  Updated: 12/Jun/14  Resolved: 11/Jun/14

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: None
Fix Version/s: 1.0

Type: Sub-task Priority: Neutral
Reporter: Philip Mundt Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-5771 Make MarkNodeAsDeletedCommand extendable Closed
depends upon MGNLPN-105 Implement delete method in BaseVarian... Closed
Template:
Date of First Response:

 Comments   
Comment by Roman Kovařík [ 13/May/14 ]

The deletion works as follows:

  1. A variant node is marked as deleted.
  2. A parent 'variants' node is marked as deleted if it was the last variant.
  3. We cannot remove mixing at this point because someone can still restore undeleted version.

We would need custom implementation for actions:

  • restore previous version
  • activate deletion
    only because of HAS_VARIANT_MIXIN. -I would suggest to get rid of this mixing and check existence of variants node instead.-

-Committed solution without deletion of this mixing.-
-This mixin is currently deleted only when there is no active subscriber (uses info.magnolia.personalization.variant.BaseVariantManager.deleteVariant(Node) directly).-

Comment by Roman Kovařík [ 05/Jun/14 ]

Please wait with integration until complete solution for MGNLPN-118 will be ready.

Comment by Roman Kovařík [ 06/Jun/14 ]

Reopen: deletion of last variant has to create version of 'variants' node prior deletion

Comment by Roman Kovařík [ 11/Jun/14 ]

Reopened:

  1. confirmVariantsDeletion action should extend confirmVariantDeletion action
  2. Availability rule IsVariantRule for confirmVariantDeletion should be dropped.
Generated at Mon Feb 12 06:34:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.