[MGNLPN-13] Create registry for all segments and variants Created: 18/Feb/14  Updated: 07/May/15  Resolved: 27/May/14

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: None
Fix Version/s: 1.0

Type: Task Priority: Neutral
Reporter: Philip Mundt Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLPN-209 Improve performance of personalizatio... Closed
dependency
depends upon MAGNOLIA-5779 Add possibility to observe whole work... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Personalisation

 Description   

Registry has to be updated during runtime and filled upon startup.
It has to contain all segments and variants in the system.



 Comments   
Comment by Philip Mundt [ 20/May/14 ]

Solved on branch "MGNLPN-13-clean"

Comment by Roman Kovařík [ 20/May/14 ]
  • ConfiguredVariantObservingManagerTest:
    • could probably extend AbstractPersonalizationTestCase
    • or MgnlContext.setInstance(null) is missing in tearDown()
    • same for ConfiguredSegmentObservingManagerTest
  • CreateVariantCommandTest:
    + assertThat(node.getNode(VariantManager.VARIANTS + "/variant-0"), not(nullValue())); //this test was wrong already before, it doesn't return null in case of a failure but it throws PNFE
  • Shouldn't we use static loggers?(info.magnolia.personalization.registry.WorkspaceObservingManager)
    + private final Logger log = LoggerFactory.getLogger(getClass());
  • Will be WorkspaceObservingManager moved to core?
  • One stupid question:
  • It this the valid apostrophe?
    +public class Variant {
    +
    +    /**
    +     * The variant`s itemId.
    +     */
    
Comment by Roman Kovařík [ 27/May/14 ]
  1. ConfiguredSegmentObservingManager doesn't register segments from folders. This is due to fact that we use NodeUtil.visit() only for mgnl:segment node type. We should probably use a query.
  2. Incorrect message in info.magnolia.personalization.registry.variant.ConfiguredVariantObservingManager.createProvider(Node):
    log.error("Unable to create segment provider for segment [{}]", variantNode.getPath(), e);
    
Comment by Philip Mundt [ 27/May/14 ]

Commit:
https://git.magnolia-cms.com/gitweb/?p=enterprise/personalization.git;a=commitdiff;h=94ab3e5d854c5cca046cfeb065f0dc3ae48e0ff4

Generated at Mon Feb 12 06:33:27 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.