[MGNLPN-139] VariantResolver should not be triggered in preview app Created: 04/Jun/14  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: None
Fix Version/s: 1.1.x

Type: Bug Priority: Critical
Reporter: Roman Kovařík Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLPN-184 Switching to original of a page in pa... Closed
relation
is related to MGNLPN-131 VariantResolver should not be trigger... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

This is the follow up ticket for MGNLPN-131 which disabled variant resolution in pages app, but resolution of variants in VariantResolverFilter in case of preview app is still not skipped.

Problem

There might be situations where variant resolving might be triggered when in AdminMode (in the PageEditor or in PreviewApp without explicitly setting preview parameters). For example:

  • mainNode
    • variant-0 (trait: date=today)
    • variant-1 (trait: userAgent=Firefox) (using Firefox for preview)
  • In PreviewApp we want to maintain variant resolution! But we don't to resolve a variation without specified parameters (e.g. opening the preview app)

How to reproduce on localhost

"Attach" a date trait with the date set the "today" (See above example).

Suggested solution

https://developer.mozilla.org/en-US/docs/Web/HTTP/X-Frame-Options (this can't be used as this header is not set)

We should use the GET parameter mgnlVariant to identify a needed bypass of the filter as this parameter is not used in the PreviewApp.



 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 06:34:41 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.