[MGNLPN-189] Remove personalisation-specific cache configuration Created: 08/Oct/14 Updated: 22/Jan/15 Resolved: 07/Nov/14 |
|
| Status: | Closed |
| Project: | Magnolia Personalization |
| Component/s: | Integration |
| Affects Version/s: | None |
| Fix Version/s: | 1.1 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | cache | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
| Comments |
| Comment by Magnolia International [ 09/Oct/14 ] |
|
Am not convinced about the change to the VariantResolverFilter and the removal of BypassVariantsCacheStore
|
| Comment by Roman Kovařík [ 09/Oct/14 ] |
I tried that or just create voter for that but the problem is that we don't have the necessary information in AggregationState yet. All what we have is just URI.
I see your point. I wanted to get rid of p13n specific configuration at all because if you'd need a more specific store, you'd need to implement one for CE and one for EE.
It does
|
| Comment by Magnolia International [ 13/Oct/14 ] |
Agreed on both point; the stuff I'm suggesting would require more changes in Cache module, I'm aware it's not possible as-is with the current API.
The problem is not so much the effect of the header itself than the fact that it's a hidden side-effect, and that the day it'll be a problem for someone somewhere, it'll be harder to track down that necessary. |
| Comment by Roman Kovařík [ 13/Oct/14 ] |
|
Does it make sense to use |
| Comment by Magnolia International [ 15/Oct/14 ] |
|
I like the decoupling this permits between cache-Store and p13n. I don't like the "magic number" approach. Did you think of any possible alternatives ? (incl deeper changes to cache apis) |
| Comment by Roman Kovařík [ 24/Oct/14 ] |
|
Reopen: adjust to changes in depending ticket. |
| Comment by Roman Kovařík [ 29/Oct/14 ] |
|
Review by architects:
|
| Comment by Roman Kovařík [ 29/Oct/14 ] |
|