[MGNLPN-191] Variant icons do not get removed in pages app Created: 31/Oct/14  Updated: 01/Dec/14  Resolved: 26/Nov/14

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: 1.0.1
Fix Version/s: 1.1

Type: Bug Priority: Major
Reporter: Lars Fischer Assignee: Espen Jervidalo
Resolution: Won't Fix Votes: 0
Labels: support, uzh
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The variant icon does not get removed after deleting variants when the standard workflow is not used.

To reproduce

  1. open: http://demoauthor.magnolia-cms.com/.magnolia/admincentral#app:configuration:browser;/modules/pages/commands/website/activate@commandName:treeview:
  2. instead of workflow-activate use versioned-activate
  3. create a page variant
  4. page variant icon is displayed
  5. delete page variant
  6. variant icon is still there


 Comments   
Comment by Roman Kovařík [ 06/Nov/14 ]

There were thoughts to use observation to handle variant mixin / variants node changes so we could get rid off personalization specific activation commands completely.

Comment by Espen Jervidalo [ 26/Nov/14 ]

First of all: To reproduce this ticket, you need to publish the deletion of your variant.

Second: This is not a bug: If you change the activation command to versioned-activate you do not take care of deleting the variant mixin in the parent node. which is correct. To do that, you should use the "personalizationActivation" command from "/personalization-integration/commands/default" catalog which takes care of cleaning up the variation mixin from the parent.

See info.magnolia.personalization.command.PersonalizationActivationCommand#execute

Generated at Mon Feb 12 06:35:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.