[MGNLPN-200] Personalization filters should trigger only for text/html Created: 11/Feb/15  Updated: 15/Apr/16  Resolved: 02/Oct/15

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: 1.1
Fix Version/s: 1.2.2

Type: Bug Priority: Major
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1h 5m
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLPN-238 VariantResolverFilter should only tri... Closed
dependency
is depended upon by EXTTRAITS-2 Remove workaround for MGNLPN-200 Closed
duplicate
is duplicated by MGNLPN-161 AbstractTraitDetectorFilter should be... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Kromeriz 13
Story Points: 1

 Description   

A ResponseContentTypeVoter should be probably added to VariantResolverFilter and all trait detectors filters.



 Comments   
Comment by Roman Kovařík [ 02/Oct/15 ]

Implementation: programatically added bypass since we plan to support personalization for other content types so we don't need to care about update tasks now and later. This will be also overridden with a custom bypasses so it's more or less compatible.

Comment by Philip Mundt [ 24/Nov/15 ]

I wonder how this could pass QA as it was clearly not tested!?!?

What was added to info.magnolia.personalization.filter.VariantResolverFilter#VariantResolverFilter() is basically dead code: the addBypass(); calls for both voters are missing.

Created follow-up, tests and fix.

Generated at Mon Feb 12 06:35:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.