[MGNLPN-201] Allow to cache variants Created: 16/Feb/15  Updated: 25/Jun/15  Resolved: 23/Feb/15

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: None
Fix Version/s: 1.2

Type: Improvement Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: cache
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLADVCACHE-57 Extract variant caching from Personal... Closed
relates to MGNLPN-219 Extract variant caching from Personal... Closed
dependency
depends upon MGNLCACHE-87 Allow to customize cache entries / ca... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Comments   
Comment by Jan Haderka [ 23/Feb/15 ]

aggregationState.setMainContentNode(variant); //we set the node here so info.magnolia.personalization.cache.PersonalizedCacheKeyGenerator can use this information

I don't think it's good idea to manipulate aggregation state from cache policy. You should find different way to get name of the node or the node itself around. Perhaps request attribute would suffice.

Comment by Jan Haderka [ 23/Feb/15 ]

protected static final String REQUEST_ATTRIBUTE_VARIANT = "mgnlCacheVarint";

typo?

Generated at Mon Feb 12 06:35:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.