[MGNLPN-204] Support for non-jcr segments Created: 20/Mar/15  Updated: 23/Jun/15  Resolved: 31/Mar/15

Status: Closed
Project: Magnolia Personalization
Component/s: Integration, Segmentation App
Affects Version/s: None
Fix Version/s: 1.1.1

Type: Improvement Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLPN-217 MigrateAssignedSegmentsValuesTask fails Closed
dependency
is depended upon by MGNLWCS-107 Implement app for WCS segments Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

The chooser for segments currently offers only segments from segments workspace. We should provide connector which sees all segments from SegmentRegistry (doesn't need to be installed be default).



 Comments   
Comment by Philip Mundt [ 27/Mar/15 ]
  • SegmentSelectFieldFactory should inject SegmentRegistry (it's a new class so that's not a problem)
  • Segment#identifier should be Segment#id
    • This ID should be "generated" by SegmentRegistryImpl and should follow the pattern module-name:relative-path-to-segement
    • It should not be a JCR identifier
    • This will simplify info.magnolia.personalization.segmentation.app.SegmentationMultiField#validate (we will be able to get rid of all the current checks and simply check for uniqueness of the key)
    • An alternative would be to add an equals method to the Segment

With the above changes we get "closer" to being ready for 5.4 config registries and we should indeed create a follow-up ticket that will implement the new Registry for the SegmentRegistry. You will be able to easily add a ConfigurationSource for the external segments.

Comment by Philip Mundt [ 02/Apr/15 ]

QAd on 5.3.8-SNAPSHOT and 5.4-SNAPSHOT bundles.

Generated at Mon Feb 12 06:35:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.