[MGNLPN-217] MigrateAssignedSegmentsValuesTask fails Created: 23/Jun/15  Updated: 30/Jun/15  Resolved: 29/Jun/15

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: 1.1.1
Fix Version/s: 1.1.2

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLPN-204 Support for non-jcr segments Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

This is due to wrong and redundant code:
line 75: Node segment = session.getNodeByIdentifier(oldValues[i].getString());

2015-06-22 16:43:07,513 WARN  info.magnolia.module.delta.PartialBootstrapTask   : Deleted already existing node for bootstrapping: /modules/rssaggregator/apps/rssAggregator/subApps/detail/editor/form/tabs/scheduleTab/fields
2015-06-22 16:43:14,027 ERROR nalization.setup.MigrateAssignedSegmentsValuesTask: Cannot migrate assigned segments values for node node /demo-project/variants/variant-0.
javax.jcr.ItemNotFoundException: 6896dff6-1584-4a26-be96-2ca5f5a04ac8
	at org.apache.jackrabbit.core.ItemManager.getItemData(ItemManager.java:384)
	at org.apache.jackrabbit.core.ItemManager.getItem(ItemManager.java:328)
	at org.apache.jackrabbit.core.ItemManager.getItem(ItemManager.java:622)
	at org.apache.jackrabbit.core.SessionImpl.getNodeById(SessionImpl.java:536)
	at org.apache.jackrabbit.core.SessionImpl.getNodeByIdentifier(SessionImpl.java:1102)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.getNodeByIdentifier(DelegateSessionWrapper.java:182)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.getNodeByIdentifier(DelegateSessionWrapper.java:182)
	at info.magnolia.jcr.wrapper.NodeWrappingDelegateSessionWrapper.getNodeByIdentifier(NodeWrappingDelegateSessionWrapper.java:58)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.getNodeByIdentifier(DelegateSessionWrapper.java:182)
	at info.magnolia.jcr.decoration.ContentDecoratorSessionWrapper.getNodeByIdentifier(ContentDecoratorSessionWrapper.java:129)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.getNodeByIdentifier(DelegateSessionWrapper.java:182)
	at info.magnolia.jcr.decoration.ContentDecoratorSessionWrapper.getNodeByIdentifier(ContentDecoratorSessionWrapper.java:129)
	at info.magnolia.personalization.setup.MigrateAssignedSegmentsValuesTask.operateOnNode(MigrateAssignedSegmentsValuesTask.java:75)
	at info.magnolia.module.delta.NodeVisitorTask$1.visit(NodeVisitorTask.java:74)
	at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:656)
	at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658)
	at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658)
	at info.magnolia.jcr.util.NodeUtil.visit(NodeUtil.java:658)
	at info.magnolia.module.delta.NodeVisitorTask.doExecute(NodeVisitorTask.java:82)
	at info.magnolia.module.delta.AbstractRepositoryTask.execute(AbstractRepositoryTask.java:57)
	at info.magnolia.module.ModuleManagerImpl.applyDeltas(ModuleManagerImpl.java:514)
	at info.magnolia.module.ModuleManagerImpl.installOrUpdateModule(ModuleManagerImpl.java:496)
	at info.magnolia.module.ModuleManagerImpl$1.doExec(ModuleManagerImpl.java:274)
	at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:414)
	at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:411)
	at info.magnolia.context.MgnlContext.doInSystemContext(MgnlContext.java:385)
	at info.magnolia.module.ModuleManagerImpl.performInstallOrUpdate(ModuleManagerImpl.java:268)
	at info.magnolia.module.ui.ModuleManagerWebUI$2.run(ModuleManagerWebUI.java:124)
	at java.lang.Thread.run(Thread.java:745)
2015-06-22 16:43:14,037 ERROR nalization.setup.MigrateAssignedSegmentsValuesTask: Cannot migrate assigned segments values for node node /demo-project/variants/variant-1.
javax.jcr.ItemNotFoundException: 7c178722-5347-418f-af81-e95e40ca95d3
	at org.apache.jackrabbit.core.ItemManager.getItemData(ItemManager.java:384)
	at org.apache.jackrabbit.core.ItemManager.getItem(ItemManager.java:328)
	at org.apache.jackrabbit.core.ItemManager.getItem(ItemManager.java:622)


 Comments   
Comment by Philip Mundt [ 24/Jun/15 ]

Does this issue have to be foward-ported to 1.2?

Comment by Roman Kovařík [ 24/Jun/15 ]

Yes, it has.

Comment by Roman Kovařík [ 29/Jun/15 ]

Reopened:

  1. The task should be moved to current delta.
  2. Since we provided a patch for 1.1.1, we should check if the values hasn't been migrated yet.
Generated at Mon Feb 12 06:35:28 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.