[MGNLPN-226] STK's navigation doesn't show variant's title anymore due to TemplatingFunctions resolving the master node (siteRoot) Created: 27/Jul/15  Updated: 29/Oct/15  Resolved: 12/Aug/15

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: None
Fix Version/s: 1.2.1

Type: Bug Priority: Blocker
Reporter: Philip Mundt Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: 541backlog
Remaining Estimate: 0d
Time Spent: 1h
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLPN-224 Getting the siteRoot from a variant p... Closed
relation
is related to MGNLPN-233 Navigation doesn't respect titles set... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Sprint 5 (Basel)
Story Points: 8

 Description   

MGNLPN-224 introduced VariantAwareTemplatingFunctions that resolve the master node when a variant is given. This now causes trouble with STK's navigation model, as the variant's title is not shown anymore.

Side effects

Failing UI tests:

  • info.magnolia.eeintegrationtests.uitest.PersonalizationUITest.testStandardPersonalizationWorkflow(): Variant's title is not shown anymore


 Comments   
Comment by Espen Jervidalo [ 07/Aug/15 ]

After a discussion with had and rkovarik we decided to revert the change we did for MGNLPN-224 where we unwrap the variant node in info.magnolia.personalization.templating.VariantAwareTemplatingFunctions#page
Instead we will do the unwrapping where it actually fails in info.magnolia.rendering.template.type.TemplateTypeHelper#getContentListByTemplateIds, when we resolve the site- or search-roots path. We will again have to provide a variant-aware implementation and replace the original one, as the rendering-module has no knowledge about variants.
Using Node-API was dismissed, due to performance- and memory-concerns.

Comment by Espen Jervidalo [ 12/Aug/15 ]

So this ticket was re-opened by ilgun because the navigation is still not working when opening a variant inside the page-editor. It works on public and also using the previews-as-visitor-app. Apparently this is a known problem in personalization and already present in 5.3. I will create a follow-up ticket and re-resolve this one.

EDIT: After discussions with pmundt we came to the conclusion that this is intended behavior. If we would wrap the the content node in page-editing mode, we would end up editing the page and not the variation. So the navigation being broken is a side effect of this which we are aware of.

Generated at Mon Feb 12 06:35:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.