[MGNLPN-235] Investigation for MGNLPN-233 Created: 12/Nov/15  Updated: 20/Nov/15  Resolved: 18/Nov/15

Status: Closed
Project: Magnolia Personalization
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Neutral
Reporter: Michael Mühlebach Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLPN-233 Navigation doesn't respect titles set... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Sprint: Kromeriz 19
Story Points: 5

 Description   

Timebox: 2d
----------

Questions to be answers among others:

  • Feasible for 5.4 or not
  • Estimation for solving the issue
  • Should this wait for component based personalization


 Comments   
Comment by Roman Kovařík [ 16/Nov/15 ]

Result:

  • info.magnolia.personalization.filter.VariantResolverFilter#resolveVariant
    • should always wrap the page node, not only if it's a variant
    • this goes forward to component personalization where we will probably get rid of the variant resolver filter altogether in M5 and personalization node wrapper will be used by default for all workspaces.
    • the logic to resolve the correct variation node should happen into the constructor info.magnolia.personalization.decoration.PersonalizationNodeWrapper#PersonalizationNodeWrapper
      • This shouldn't be a performance problem, since we use a sort of cache (variant mapping).
  • info.magnolia.personalization.decoration.PersonalizationContentDecorator#wrapNode should wrap only if the node is not already wrapped.
Generated at Mon Feb 12 06:35:39 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.