[MGNLPN-331] VariantManager#VARIANT_NODE_PATH_PATTERN matches incorrecly for non variant in a variant Created: 19/Sep/16  Updated: 15/Dec/16  Resolved: 04/Nov/16

Status: Closed
Project: Magnolia Personalization
Component/s: Component p13n
Affects Version/s: 1.3
Fix Version/s: 1.3.1, 1.4

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
dependency
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Sprint: Kromeriz 68
Story Points: 3

 Description   

?variant-([0-9]+) matches incorrectly nodes in a variant. As this is not an issue for a page variant (since we don't support subpages), it's a problem for component personalization:
/page/area/component/variants/variant-0/componentInVariant
namely in:
info.magnolia.personalization.decoration.PersonalizationNodeWrapper#PersonalizationNodeWrapper:

....
} else if (VARIANT_NODE_PATH_PATTERN.matcher(wrapped.getPath()).find()) { //should match rather node name instead of path or just the end of the path
          //HERE     
} else if
...

Generated at Mon Feb 12 06:36:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.