[MGNLPN-336] Add switcher to wrap only personalized pages to improve performance Created: 23/Sep/16  Updated: 09/Feb/17  Resolved: 08/Nov/16

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: 1.2, 1.3
Fix Version/s: 1.2.8, 1.3.1, 1.4

Type: Bug Priority: Major
Reporter: Jaroslav Simak Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLPN-344 Performance issues while wrapping no... Closed
causality
caused by MGNLPN-233 Navigation doesn't respect titles set... Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Documentation update required:
Yes
Date of First Response:
Sprint: Kromeriz 65
Story Points: 2

 Description   

Until MGNLPN-233, we were wrapping nodes with PersonalizationNodeWrapper only if the given page had a variant. This resulted in some issues (e.g. displaying the original titles in navigation when viewing it on pages without variant). MGNLPN-233 fixed this issue, but the performance was severely affected.

The optional switch wrapOnlyPersonalizedNodes is therefore added to /server/filters/cms/variantResolver. (default is false)



 Comments   
Comment by Evzen Fochr [ 08/Oct/16 ]

Cannot find usage of personalization 1.3.1

Comment by Evzen Fochr [ 10/Oct/16 ]

rename not logically named variable hasPersonalizedVariant to wrapNode, functionality is ok.

Comment by Roman Kovařík [ 20/Oct/16 ]

Reopened:

  • the fix breaks cp13n since it doesn't use guice to get the correct impl of the node wrapper. As result, component variants can be edited via dialog, but in the page editor is always only the original visible.
Comment by Roman Kovařík [ 24/Oct/16 ]

Resolved:

  • The switcher is staying, the guice is still used (commit c94f7766fc04842f5a324b934d1144d5b9cee3c9 was reverted from 1.2.x, 1.3.x and master).
Comment by Roman Kovařík [ 27/Oct/16 ]

Closed:
The final solution has only the switcher, guice is still used.

Comment by Jan Haderka [ 01/Nov/16 ]

Switching off the wrapping is not "solution", it's just a workaround as when switched off, the fix for MGNLPN-233 is not working.

We need to find solution that avoids MGNLPN-233 and doesn't make user suffer performance wise either.

Comment by Roman Kovařík [ 12/Dec/16 ]

We need to find solution that avoids MGNLPN-233 and doesn't make user suffer performance wise either.

Solved by MGNLPN-344.

Generated at Mon Feb 12 06:36:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.