[MGNLPN-423] Regression: can't choose a cookie value when targeting a variant Created: 13/Jun/18  Updated: 15/Jun/18  Resolved: 14/Jun/18

Status: Closed
Project: Magnolia Personalization
Component/s: None
Affects Version/s: None
Fix Version/s: 1.6

Type: Bug Priority: Blocker
Reporter: Antti Hietala Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File 1-cookie-trait-current.png     PNG File 2-cookie-trait-regression.png    
Issue Links:
Problem/Incident
is caused by MGNLPN-410 Use GDPR-compliant cookie manager Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Kromeriz 151
Story Points: 2

 Description   

MGNLDEMO-286 introduced a regression issue for personalization functionality. The user can no longer pick a cookie trait AND a value for the cookie when targeting a personalized variant. They can only see the list of cookie_value pairs from the Cookie Manager app. Functionality was lost. 

Reason: Cookie configuration was moved from /modules/personalization-traits to /modules/cookie-manager and the node structure changed. Each cookie can only have a single value in the value property. Before, each cookie could have multiple values.

This means that users now have to create multiple redundant cookie_value pairs in the Cookie Manager to replicate their old cookie configuration. It also means that users must choose from a long list of cookie_value pairs when targeting a variant.

Imagine the following scenario:

Before After
Cookie: mealType 
Values: meat, vegetarian, vegan, halal, carrots-only
mealType_meat
mealType_vegetarian
mealType_vegan
mealType_halal
mealType_carrots-only


 Comments   
Comment by Roman Kovařík [ 13/Jun/18 ]

The suggested solution is to 

  • revert all the changes for the cookie trait (keeping the visitor trait changes)
  • optionally keep the cookie definitions for weatherLocality and tourType 

Revert this: https://git.magnolia-cms.com/projects/ENTERPRISE/repos/personalization/pull-requests/199/commits/f304e1c8527a336b173ab36e97379385a5ee004e#magnolia-personalization-blossom/pom.xml

And partially this: https://git.magnolia-cms.com/projects/ENTERPRISE/repos/personalization/pull-requests/199/commits/67844fa49afc41c87336763fc57c6fc47e01237e#magnolia-personalization-traits/src/main/java/info/magnolia/personalization/cookie/CookieFieldTransformer.java

Generated at Mon Feb 12 06:37:29 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.