[MGNLPN-431] Port Personalization preview app to the resurface UI Created: 06/Nov/18  Updated: 20/Nov/18  Resolved: 14/Nov/18

Status: Closed
Project: Magnolia Personalization
Component/s: Preview App
Affects Version/s: None
Fix Version/s: 1.7

Type: Bug Priority: Major
Reporter: Mikaël Geljić Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1d 5.5h
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLPN-433 Resurface field type: custom field ty... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Resurface theme
Sprint: Saigon 158
Story Points: 5

 Description   

Acceptance criteria:

  • Move the view out of the dialog and back into a normal app (Plain, regular app with a tabsheet layout. Could be based on the old UI framework.)
  • Don't attempt full screen like in M5 yet. We do that in a follow up.
  • Don't attempt action bar restyling. We do that in a follow up as well.

Background

—currently accidentally ended up displayed in a dialog

https://slack-files.com/T4J2HS2LU-FDWTKE8E6-9be3065ab5

Mikaël Geljić [15:45]
@Ilgun re: p13n preview app, my guess is that this used to call the deprecated overlay API directly—now the new Shell wraps any "unknown view" into a dialog. When you close the dialog, it doesn't close the background app that was started. There was also a special hook for closing the app in the old impl iirc. We should probably adjust this app for M6 (with new major of p13n), and make it a real app instead of an overlay?

Aleksandr Pchelintcev [15:46]
for that we’d need to expand the API for opening the apps beyond the tabsheet limits

Mikaël Geljić [15:47]
would it be that bad if it were a regular subapp?

Aleksandr Pchelintcev [15:48]
dunno, I think the whole purpose of the app initially was to provide the real experience without mgnl

Mikaël Geljić [15:48]
at least in a first step; with a custom AppView impl you don't necessarily need the tabsheet btw, but I'm not sure whether the app/instance controllers are fully lenient there

Aleksandr Pchelintcev [15:48]
they should be actually - worth checking out
re: closing the app now - I think it should be still doable iirc it was based on the app lifecycle events



 Comments   
Comment by Antti Hietala [ 08/Nov/18 ]

mgeljic / avongunten, decided to split ticket into immediately actionable "appification" and later we do proper styling.

Comment by Dai Ha [ 19/Nov/18 ]

Verified with magnolia-enterprise-pro-demo-bundle-6.0-20181118.232456-634-tomcat-bundle.zip
Preview app now is being opened as a new tab.

Generated at Mon Feb 12 06:37:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.