[MGNLPN-432] Trait picker dialog throws exception and is partially broken Created: 08/Nov/18  Updated: 15/Nov/18  Resolved: 13/Nov/18

Status: Closed
Project: Magnolia Personalization
Component/s: None
Affects Version/s: None
Fix Version/s: 1.6.2

Type: Bug Priority: Neutral
Reporter: Christoph Meier Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.5h
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2018-11-13 at 14.41.34.png     PNG File Screen Shot 2018-11-13 at 14.43.23.png     PNG File Screen Shot 2018-11-13 at 14.50.46.png     Text File buttonClickerr.txt     PNG File preview-app-traits.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Resurface polishing
Sprint: Kromeriz 165
Story Points: 8

 Description   

While rendering the "Pick trait" dialog - an exception is thrown.

To reproduce, method 1:

  1. Open the Pages app.
  2. Select a variant of the /travel/contact page and click the Choose audience action.
  3. Pick a trait and close the dialog. --> Exception thrown. 

To reproduce, method 2:

  1. On the preview app while adding traits

Caused by: java.lang.ClassCastException: info.magnolia.ui.dialog.DialogComponent cannot be cast to com.vaadin.ui.SingleComponentContainer

See stacktrace(s): https://goo.gl/Y9Ui7t, https://goo.gl/X3haqQ

On (1) - during the choose audience - you can pick the first trait, choose its value. 
But from now on you cannot pick additional traits.
Use the button pick to save the first trait and restart the choose audience procedure for the 2nd trait.

-On (2) - on the preview app, the layout has issues and the preview app is "damaging" the layout of the shell, but that's another issue, see screenshot preview-app-traits.png.-  MGNLPN-431



 Comments   
Comment by Roman Kovařík [ 12/Nov/18 ]

On (1) - during the choose audience - you can pick the first trait, choose its value. 
But from now on you cannot pick additional traits.

Can't reproduce with the latest bundle.

Comment by Bradley Andersen [ 13/Nov/18 ]

This seems to be broken for me, using latest, unless I misunderstand the issue.  I create page, I add a variant, I select an audience (trait = audience, picked china), and on save I get:

 

 

Comment by Roman Kovařík [ 13/Nov/18 ]

The p13n version in the bundle was just updated.

Generated at Mon Feb 12 06:37:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.