[MGNLPN-445] Migrate personas app to new UI framework Created: 22/Oct/19  Updated: 06/Oct/20  Resolved: 14/Jan/20

Status: Closed
Project: Magnolia Personalization
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0

Type: Task Priority: Neutral
Reporter: Roman Kovařík Assignee: Michael Duerig
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 3h 55m
Time Spent: 1h 25m
Original Estimate: Not Specified

Attachments: PNG File activation-column-width.png     File edit-persona-fails-and-wrong-image-field-order.mov     PNG File image-2020-01-17-15-55-21-533.png     File move-persona-fails.mov     File rename-persona-dialog-title-and-position-incorrecr.mov     File show-versions-fails.mov    
Issue Links:
Cloners
is cloned by MGNLPN-469 UX consolidation for migrated Persona... Closed
Problem/Incident
causes MGNLUI-6280 DEV DOC: Investigate Personalization ... Closed
dependency
depends upon MGNLUI-5574 Add width, minimumWidth, maximumWidth... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Migrate apps to new UI framework
Sprint: UI Framework 12, UI Framework 13, UI Framework 14
Story Points: 5

 Description   

Move current app to compatibility module and create new one based on new framework.



 Comments   
Comment by Michael Duerig [ 13/Jan/20 ]

Reopening to fix. https://jenkins.magnolia-cms.com/job/dx-core/job/master/583/

Comment by Michael Duerig [ 13/Jan/20 ]

Reopen for fixing https://jenkins.magnolia-cms.com/blue/organizations/jenkins/dx-core/detail/master/589/tests

Comment by Rishab Dhar [ 17/Jan/20 ]

mduerig The following bugs were discovered during QA, please find attached videos on how to reproduce the bugs:

  1. Edit Persona action fails - there are two issues :
    • Complex field image field ordering is incorrect (the image should be on the top with descriptor fields at bottom). Additionally, the indentation of this field is incorrect.
    • Editing an image in media editor and triggering save does not update the image in preview or when it is reopened for editing. However, as the Show versions action becomes visible, most likely the image got saved, but the UI does not use the newer version of the image. This could also be the reason for another action - Show Versions failing.
  2. Rename Persona action - there are two issues:
    • The dialog for rename persona is not placed at the center, like in the old app, but rather aligned to the top.
    • The dialog title Rename is inconsistent to the old app where the dialog title is Rename Persona
  3. Move Persona action does not successfully move the persona to the selected location.
  4. Show versions action fails and throws and error Notification. Worth looking into issue in 1) as the possible cause.
  5. Restore version action even when enabled is not clickable. This issue was also experienced in the old app. Possible cause could be shadowing of the action from the image preview.
  6. Activation Status column width is too small, and does not display the full label. 
Comment by Michael Duerig [ 17/Jan/20 ]

Re. moving personas: this works for me. Result looks like this: While this is equal to the 6.1, I wonder whether it is correct. IMO a persona should only be movable into a folder.

Comment by Michael Duerig [ 17/Jan/20 ]

Re. Complex field image field ordering is incorrect for the image: DAM has the same problem, so this is maybe an issue with the composite field.

Comment by Michael Duerig [ 17/Jan/20 ]

Re. editing the image: this doesn't work for me at all. I.e. the edited image is never saved but I also don't see versions becoming available. Again this is maybe an issue with the image filed as DAM also has the same issues again.

Comment by Michael Duerig [ 17/Jan/20 ]

Re. placement of the rename dialog: placement of that dialog is the same for me in the old app and in the new one.

Comment by Michael Duerig [ 17/Jan/20 ]

Show and restore versions also don't work correctly for me but in a different way: clicking on the action brings up the "Show versions" dialog. But the "Version" drop down is not clickable.

Comment by Roman Kovařík [ 20/Jan/20 ]

Looks like the trait multifield is missing the delete button.

Comment by Michael Duerig [ 20/Jan/20 ]

Re. placement of the rename dialog, according to fgrilli this is intended: MGNLUI-5426

Comment by Rishab Dhar [ 20/Jan/20 ]

mduerig Updated the comment w.r.t dialog positioning.

Comment by Michael Duerig [ 20/Jan/20 ]
  1. Edit Persona
  2. Rename Persona
  1. Move Persona
    • Could not reproduce. OTOH there is also MGNLPN-173
  1. Show versions
  1. Restore version
  1. Activation Status

rdhar, with this all issues found in QA should be addressed and I think we can close this issue.

Generated at Mon Feb 12 06:37:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.