As a marketing manager, I can also preview the website as a specific Persona so that I can see whether my segmentation works. (MGNLPN-28)

[MGNLPN-48] Make PreviewFilter persona aware Created: 25/Mar/14  Updated: 26/Mar/14  Resolved: 25/Mar/14

Status: Closed
Project: Magnolia Personalization
Component/s: Preview App
Affects Version/s: None
Fix Version/s: 1.0

Type: Sub-task Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLPN-53 Get rid of circular dependency betwee... Closed
Template:
Date of First Response:
Sprint: 5.3 Sprint 4

 Description   
  1. Check if a persona parameter is in the request.
  2. Get persona node by UUID.
  3. Use previewParameterDefinitions from PreviewModule to get persona's trait properties from node
    • info.magnolia.p13n.preview.parameter.PreviewParameterDefinition#getName() = node's propertyName
    • Use converter to get instance of trait to store in PreviewTraitCollector
  4. Merge persona properties with others preview parameters.


 Comments   
Comment by Roman Kovařík [ 25/Mar/14 ]

Commit:
https://git.magnolia-cms.com/gitweb/?p=enterprise/p13n.git;a=commitdiff;h=d181732348f5b42ef22130db28b831b1536bae9c

Comment by Philip Mundt [ 25/Mar/14 ]

Minor remarks:

  • Please do not use a class variable for the persona Node
    • change signature of relevant method to private String getParameterFromPersona(Node, String)
  • Do not assign PreviewAppModule to variable in doFilter(HttpServletRequest, HttpServletResponse, FilterChain), use previewAppModuleProvider.get() instead
  • in getPersona(HttpServletRequest) use getPrefixedParameterName(String) to get personaParameterName
  • in PersonasAppModule use same 'order' for modifiers
Comment by Roman Kovařík [ 25/Mar/14 ]

Commits:
https://git.magnolia-cms.com/gitweb/?p=enterprise/p13n.git;a=commitdiff;h=173b762f9d01574fab2735b0558798b0101b60ee
https://git.magnolia-cms.com/gitweb/?p=enterprise/p13n.git;a=commitdiff;h=230fad7c044494ade1bcf1b5172c6f882463ee0b

Generated at Mon Feb 12 06:33:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.