[MGNLPN-480] Delete action should not be available when no item is selected Created: 12/Mar/20  Updated: 11/Mar/21  Resolved: 11/Mar/21

Status: Closed
Project: Magnolia Personalization
Component/s: Personas App
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Michael Duerig Assignee: Unassigned
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Under some specific circumstances the delete action becomes available even though no item is selected.

Steps to reproduce

With Personas app freshly started: * Add persona, then Cancel from footer (important!)

  • back in browser, Action bar is displayed for Multiple items, despite nothing selected
  • (hitting Delete items apparently attempts to delete the root)

Expected behaviour

Only the default items should be available from the action bar (those that are shown when the app is initially started).

Initial analysis

After cancelling the add persona action DefaultAvailabilityChecker#isAvailable(List<T>) receives a list with the workspace root as its only item. However, later one the code relies on List.isEmpty to special case the root handling, which is skipped in this situation.

Also the segment app shows similar issues and I strongly suspect there is a common root cause. We probable need to migrate this issue once we have a better understanding. 
 

cc mgeljic



 Comments   
Comment by Roman Kovařík [ 11/Mar/21 ]

Can't reproduce on latest https://demo.magnolia-cms.com/.magnolia/admincentral#app:personas-app:browser;/Stefanie-Baumann:add:

Generated at Mon Feb 12 06:38:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.