[MGNLPN-53] Get rid of circular dependency between preview-app and personas-app Created: 26/Mar/14  Updated: 26/Mar/14  Resolved: 26/Mar/14

Status: Closed
Project: Magnolia Personalization
Component/s: Preview App
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLPN-48 Make PreviewFilter persona aware Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: Personalisation

 Description   

Preview filter uses constants from Personas Module:

public class PersonasAppModule {

    public static final String PERSONAS_WORKSPACE = "personas";
    public static final String PERSONA_NODETYPE = NodeTypes.MGNL_PREFIX + "persona";
    public static final String PERSONA_PARAMETER = "persona";
}
  • Move constants from all submodules to one single file
    OR
  • Don't use these constants in the preview filter.


 Comments   
Comment by Roman Kovařík [ 26/Mar/14 ]

Solved by https://git.magnolia-cms.com/gitweb/?p=enterprise/p13n.git;a=commitdiff;h=79f1d86a0ad001ca58107623a9ed3a91342574d8

Generated at Mon Feb 12 06:33:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.