[MGNLPN-590] CLONE - Further Improve performance of VariantAwareTitleColumnDefinition Created: 04/Oct/21  Updated: 07/Sep/22  Resolved: 20/Apr/22

Status: Closed
Project: Magnolia Personalization
Component/s: Pages
Affects Version/s: 2.0.11
Fix Version/s: 2.1.2

Type: Bug Priority: Major
Reporter: Richard Gange Assignee: Andrei Ichimescu
Resolution: Fixed Votes: 1
Labels: VN-Analysis, VN-Testing, cs-bk, maintenance, performance
Remaining Estimate: Not Specified
Time Spent: 3d 2h 40m
Original Estimate: Not Specified

Attachments: Java Source File CachingVariantAwareTitleColumnDefinition.java    
Issue Links:
Cloners
clones MGNLPN-560 Further Improve performance of Varian... Closed
duplicate
is duplicated by MGNLPN-625 Performance of info.magnolia.pages.ap... Closed
relation
is related to PAGES-841 Duplicating a page with variants is m... Open
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: AuthorX Support
Sprint: AuthorX 7
Story Points: 5
Team: AuthorX

 Description   

MGNLPN-560 introduced a new CachingVariantAwareTitleColumnDefinition. However, this column can still be slow in some systems.

Notes
Can we improve performance if component variants are not used? There should be some setting on the column class to turn off the component variant query.

For the release notes (if spotlighted):

The CachingVariantAwareTitleColumnDefinition class has been optimised for personalised pages to render variant icons even more efficiently by keeping track of pageIdentifiers that are not stored in the user session cache.

Also noting that it's only mentioned in the RN for 6.2.11: https://docs.magnolia-cms.com/product-docs/6.2/Releases/Release-notes-for-Magnolia-CMS-6.2.11.html#_notable_bug_fixes and in the nexus so far. 



 Comments   
Comment by Rico Jansen [ 14/Mar/22 ]

As ConfiguredVariantObservingManager uses the same query and uses that to keep track of the list of variant nodes in Magnolia (using observation to keep it up to date). It looks like that code could be extended to keep track of the pages using variants, or otherwise create code using a similar implimentation to that one.

Comment by Michiel Meeuwissen [ 18/Mar/22 ]

Are there any plan on why this is going to be addressed?

Comment by Michiel Meeuwissen [ 18/Mar/22 ]

I attach a version that I'll propose locally. It is very much simpler, only caches (without redoing the functionallity) of its ancestor. The obvious draw back is that it caches an hour, but I suppose this can be remedied by some change observersaion mechanism, which is going to far for me right now.

Comment by Richard Gange [ 13/Apr/22 ]

Hello mihxil-

It should be released with Magnolia 6.2.19. You can view the changes and PR here.

Regards
Rich

Generated at Mon Feb 12 06:39:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.