[MGNLPN-603] Misleading warnings in SPA project: iframe_navigation_tracker_connector.js script couldn't resolve iframe location Created: 25/Oct/21  Updated: 10/Nov/21  Resolved: 04/Nov/21

Status: Closed
Project: Magnolia Personalization
Component/s: None
Affects Version/s: None
Fix Version/s: 2.1.1

Type: Bug Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 0.25d
Original Estimate: Not Specified

Attachments: PNG File log-spam.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Epic Link: Headless p13n
Sprint: HL & LD 41
Story Points: 2

 Description   

TImebox to 1 day investigation. When no result then simply document the issue.

In aa SPA project: This is written to the log whenever opening the "Preview as Visitor" app.

WARN  ation.preview.ui.component.IFrameNavigationTracker: iframe_navigation_tracker_connector.js script couldn't resolve iframe location. Possibly missing <code>cms:page</code> tag or used deprecated <code>cms:init</code> tag in the template.

The warning should not be written to the log I think. As everything seems to work.

This warning will confuse developers as they work on a project as they will wonder what is wrong in their project or templates, they will search for a solution but not find one.



 Comments   
Comment by Christopher Zimmermann [ 03/Nov/21 ]

Could there be a check if its the freemarker renderer, and only put the warning if its freemarker rendering?

Comment by Christopher Zimmermann [ 03/Nov/21 ]

In the worst case, maybe we could have the spa renderer add something else to the page (instead of the unneeded and unused cms:page)... and have this check also check for that... something like <!-spa–>. But ideally this is only added when running in the context of Magnolia, not in production.

Generated at Mon Feb 12 06:39:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.