[MGNLPN-608] Editing on inherited components shouldn't be possible Created: 02/Jan/19  Updated: 16/Dec/21  Resolved: 22/Nov/21

Status: Closed
Project: Magnolia Personalization
Component/s: None
Affects Version/s: 6.2
Fix Version/s: 2.1, 2.0.13

Type: Bug Priority: Critical
Reporter: Frank Sommer Assignee: Rabie Hayoun
Resolution: Fixed Votes: 0
Labels: headless-team-support, maintenance
Remaining Estimate: 0.25h
Time Spent: 0.25h
Original Estimate: Not Specified

Attachments: PNG File inherited-components-2.png     PNG File inherited-components.png    
Issue Links:
duplicate
is duplicated by PAGES-169 Change *component* template should on... Closed
relation
is related to PAGES-169 Change *component* template should on... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Pages Maintenance 1
Story Points: 2

 Description   

It shouldn't be possible to create component variants of inherited components, because this creates content nodes on ancestor nodes.

You can reproduce this on demo author instance.

  1. open the travel about page https://demoauthor.magnolia-cms.com/.magnolia/admincentral#app:pages:detail;/travel/about:edit
  2. click on a footer component in a footer column
  3. create a component variant by action bar
  4. open the travel home page https://demoauthor.magnolia-cms.com/.magnolia/admincentral#app:pages:detail;/travel:edit where a footer component variant was created


 Comments   
Comment by Richard Gange [ 02/Jan/19 ]

The root of the problem is a missing rule class:

- name: isComponentEditable
   implementationClass: info.magnolia.pages.app.editor.availability.IsComponentEditableRule
Comment by Frank Sommer [ 02/Jan/19 ]

The action rules for "copy component" and "change template" should be enhanced, too.

Generated at Mon Feb 12 06:39:19 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.