[MGNLPN-628] Cookie named "cookies" causes exception in filter NameAndValueTraitDetectorFilter.collectCookies Created: 21/Apr/22  Updated: 03/Jan/23  Resolved: 25/Aug/22

Status: Closed
Project: Magnolia Personalization
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0.0, 2.1.5

Type: Bug Priority: Neutral
Reporter: Carlos Cantalapiedra Assignee: Marek Strucka
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 0.25d Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Problem/Incident
causality
caused by MGNLEE-680 Raise p13n-version to 2.1.x on dx-cor... Closed
duplicate
duplicates MGNLPN-675 Error 500 when a trait name and a coo... Closed
relation
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLPN-686 Implementation Sub-task Completed Marek Strucka  
MGNLPN-687 Review Sub-task Completed Roman Kovařík  
MGNLPN-688 PiQA Sub-task Completed Oanh Thai Hoang  
MGNLPN-689 QA Sub-task Completed Chuong Doan Huy  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: AuthorX Support
Sprint: DevX 17
Story Points: 0
Team: DeveloperX

 Description   

Cookie named "cookies" causes exception in filter NameAndValueTraitDetectorFilter.collectCookies

Which means magnolia login will not be possible because of http 500. This happens since Magnolia 6.2.18.

This is bypassed when already logged in and under /.magnolia, so it happens before the login.

Steps to reproduce on demo.magnolia-cms.com:

  1. Open demo.magnolia-cms.com
  2. Create cookie named "cookies"
    1. f.e. in chrome debugger (Application Tab - Cookies - create cookie named "cookies")
  3. refresh
  4. Check 500 erros is thrown

 

Workaround

Disable NameAndValueTraitDetectorFilter

 



 Comments   
Comment by Roman Kovařík [ 18/Aug/22 ]

I also see a small issue in the documentation:

https://docs.magnolia-cms.com/product-docs/6.2/Modules/List-of-modules/Personalization-module/Creating-custom-traits-without-Java/Cookies-trait-configuration.html#_new_implementation

suggests to create the trait with the name cookies which collides with the old cookies trait https://nightly.magnolia-cms.com/.magnolia/admincentral#app:configuration:browser;/modules/personalization-traits/traits/cookies:treeview:

 

Comment by Marek Strucka [ 18/Aug/22 ]

I changed the documentation you suggested.

Generated at Mon Feb 12 06:39:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.