[MGNLPN-82] Publish actions availability Created: 28/Apr/14  Updated: 07/May/14  Resolved: 07/May/14

Status: Closed
Project: Magnolia Personalization
Component/s: Integration
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
supersession
is superseded by MGNLPN-87 Review available actions on variants ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Personalisation
Sprint: 5.3 Sprint 6

 Description   

Steps to reproduce:

  1. You should be able to publish with subpages on the variants node.
  2. -You should not be able to publish a variant if the parent (variants node) is not published (the action should be disabled)-
    Publish action is actually available also for subpages whose parent is not published, this is not personalisation-related problem.


 Comments   
Comment by Roman Kovařík [ 28/Apr/14 ]

Commit:
https://git.magnolia-cms.com/gitweb/?p=enterprise/p13n.git;a=commitdiff;h=c099f4f89d3a5df832821cd16d710d475b8b9ea4

Comment by Roman Kovařík [ 30/Apr/14 ]

Commit:
https://git.magnolia-cms.com/gitweb/?p=enterprise/p13n.git;a=commitdiff;h=5ee79176fb8ec735312932d1751c1041bd1cb4aa

Comment by Philip Mundt [ 07/May/14 ]

With the new action availability it should be possible to add multiple rules as action availiability (as subnodes) rather than adding one more rule which combines them (this would make HasSubpagesAndIsNotDeletedRule redundant).

Comment by Roman Kovařík [ 07/May/14 ]

So actually AND operand is sufficient for parent rule. The problem is that it wouldn't be consistent with current configuration in the pages app which uses similar code. Current solution has couple of side effect:

  • As we mentioned, it could use multiple rules instead of custom parent rule class PageHasSubpagesAndIsNotDeletedRule.
  • Default PageHasSubpagesRule vs. personalisation HasSubpagesRule has almost the same code and there is no way to override only the necessary part.
  • Is it really necessary to have recursive activation available only for pages with subpages? (We could active also a page without subpages without any side-effect).
    -> We could improve also the default settings in the pages app.
Comment by Roman Kovařík [ 07/May/14 ]

Or maybe better...we could solve this globally for all variants node actions via special variantNode section as Mika suggested.
We can use custom publishVariants action in there so we don't have to touch anything in the pages app.
So I'm closing this ticket as obsolete...

Generated at Mon Feb 12 06:34:07 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.