[MGNLPN-89] Move preview parameter interfaces to integration module so they can be used in the trait registry Created: 05/May/14  Updated: 13/May/14  Resolved: 09/May/14

Status: Closed
Project: Magnolia Personalization
Component/s: Integration, Preview App
Affects Version/s: None
Fix Version/s: 1.0

Type: Task Priority: Neutral
Reporter: Philip Mundt Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Personalisation

 Description   

These classes should be moved:

  • info.magnolia.personalization.preview.parameter.PreviewParameterDefinition
  • info.magnolia.personalization.preview.parameter.PreviewParameterConverter

The info.magnolia.personalization.preview.filter.PreviewFilter currently uses preview parameters defined in info.magnolia.personalization.PreviewAppModule but should rather use the one that will be defined in each info.magnolia.personalization.registry.TraitDefinition (where the name of the trait will also be used as previewParameterName (prefixed accordingly)). This mean injecting the info.magnolia.personalization.registry.TraitDefinitionRegistry.

Other tasks:

  • TraitClass is defined still in both TraitDefinition and PreviewParameterDefinition. We need to get rid one of them.
  • The same applies for name property.
  • Duplicated code in PreviewParameterConverterServiceImpl vs PreviewFilter.
  • TraitDefinition should probably have enabled property.


 Comments   
Comment by Roman Kovařík [ 09/May/14 ]

Commits:
https://git.magnolia-cms.com/gitweb/?p=enterprise/personalization.git;a=shortlog;h=refs/heads/MGNLPN89

Generated at Mon Feb 12 06:34:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.