[MGNLPN-99] In preview app: Persona switcher arrows are disabled on load Created: 07/May/14 Updated: 19/May/14 Resolved: 19/May/14 |
|
| Status: | Closed |
| Project: | Magnolia Personalization |
| Component/s: | None |
| Affects Version/s: | 1.0 |
| Fix Version/s: | 1.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | Personalisation | ||||||||
| Description |
|
Uunless the url contains a "previewPersona" preview attribute, then on load the left and right arrows on the switcher are disabled. As soon as you choose a user from the dropdown, then the arrows are enabled. Technical notes: I experimented a little and did find a way to properly initialize the siwtcher. in PagePreviewSubApp#start, after the check previewLocation.hasAdditionalParameters() To add something along the lines of this in order to add a default for the previewItem: if (null == previewItem.getItemProperty("persona")){ final Property<String> property = new DefaultProperty<String>(String.class, "/"); previewItem.addItemProperty("persona",property); } But I guess you would want to query the config for the proper property instead of hardcoding "persona". |
| Comments |
| Comment by Philip Mundt [ 19/May/14 ] |
|
info.magnolia.personalization.preview.ui.parameters.PreviewParametersPresenterTest#testEventBus() fails due to missing context. MgnlContext.setInstance(ctx); needs to be added. |