[MGNLPUR-146] AuthenticationModel no longer redirects after login Created: 06/Jan/15  Updated: 30/Mar/15  Resolved: 21/Jan/15

Status: Closed
Project: Magnolia Public User Registration
Component/s: None
Affects Version/s: 2.4.1
Fix Version/s: 2.4.2

Type: Bug Priority: Major
Reporter: Richard Gange Assignee: Antonín Juran
Resolution: Fixed Votes: 0
Labels: regression, support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
dependency
is depended upon by MGNLSTK-1457 CLONE - AuthenticationModel no longer... Closed
relation
is related to MAGNOLIA-6043 LoginFilter: Allow dynamic redirects ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

If you log in as a public user you are no longer redirected to the target page.

If you log in as demo user peter / peter on:
http://localhost:8080/magnoliaPublic/demo-project/members-area/login.html

you are no longer redirected to:
http://localhost:8080/magnoliaPublic/demo-project/members-area/protected



 Comments   
Comment by Milan Divilek [ 07/Jan/15 ]

Culprit of this issue is MAGNOLIA-5991. Problem is cause by redirecting after successful login. During redirect after successful login "mgnlModelExecutionUUID" request parameter is lost so info.magnolia.rendering.model.ModelExecutionFilter doesn't trigger info.magnolia.module.publicuserregistration.frontend.action.AuthenticationModel. If we pass "mgnlModelExecutionUUID" parameter to redirect after successful login, then LoginResult is NOT_HANDLED, because login was done before. So info.magnolia.module.publicuserregistration.frontend.action.AuthenticationModel doesn't trigger redirect (to http://localhost:8080/magnoliaPublic/demo-project/members-area/protected) because login result status is not LoginResult.STATUS_SUCCEEDED

Comment by Antonín Juran [ 09/Jan/15 ]

Corrected here: http://git.magnolia-cms.com/gitweb/?p=modules/public-user-registration.git;a=commit;h=ff7f63f4c013e73f165296207fc91e034c0c72d7

Comment by Espen Jervidalo [ 19/Jan/15 ]

Please use the constant info.magnolia.cms.util.RequestDispatchUtil#REDIRECT_PREFIX for "redirect:" in info.magnolia.module.publicuserregistration.frontend.action.AuthenticationModel#executeEarly

Makes it much easier to see, who reads that value.

Comment by Espen Jervidalo [ 21/Jan/15 ]

Edited: The ce-bundle is still pointing to 2.4.1 final. The version needs to be updated in ce-bundle.
IMO the integration in 2.2.x branch was not necessary. The customer is using Magnolia 5.3.x with PUR 2.4.x

Comment by Antonín Juran [ 21/Jan/15 ]

The version has been updated in ce-bundle. The integration on 2.2.x branch was reverted because the causing ticket was not ported to 5.2.

Comment by Espen Jervidalo [ 21/Jan/15 ]

Thanks for updating the branch. Please do the same on ce_bundle master.

Comment by Antonín Juran [ 22/Jan/15 ]

There can be only mile stones and final versions not SNAPSHOTs.

Generated at Mon Feb 12 06:43:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.