[MGNLPUR-93] UserProfile is instantiated directly, ignoring user configuration Created: 22/Apr/13 Updated: 07/Oct/13 Resolved: 31/Jul/13 |
|
| Status: | Closed |
| Project: | Magnolia Public User Registration |
| Component/s: | None |
| Affects Version/s: | 1.4.3, 2.0 |
| Fix Version/s: | 1.4.4, 2.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Jan Haderka | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
For details see http://forum.magnolia-cms.com/forum/thread.html?threadId=46aafe06-f884-488a-a42f-6aecdae17def |
| Comments |
| Comment by Roman Kovařík [ 20/Jun/13 ] |
|
Methods: protected void setExtraUserProperties(User user, UserProfile userProfile) protected void updateExtraUserProperties(User user, UserProfile userProfile) in DefaultUserRegistrar were removed in favour of protected void setExtraUserProperties(User user, UserProfile userProfile, UserManager userManager) protected void updateExtraUserProperties(User user, UserProfile userProfile, UserManager userManager) without deprecating old ones, because: 1. It's not possible to change user properties without UserManager anymore. |
| Comment by Jan Haderka [ 22/Jun/13 ] |
|
DefaultUserRegistrar
|
| Comment by Jan Haderka [ 22/Jun/13 ] |
|
btw signature of setExtra... was changed o also return user object. Update method should behave the same and descr above should be updated to reflect this change. |
| Comment by Jan Haderka [ 22/Jun/13 ] |
|
One more thing - any reason for setting user profile class directly and configuring it under module config rather then requesting it via IoC and configuring it in module descriptor? |
| Comment by Jan Haderka [ 23/Jun/13 ] |
|
or to move it one step further, we should group realm and profile class props in module config and allow someone to have different profile per realm. |
| Comment by Jan Haderka [ 23/Jun/13 ] |
|
UpdateProcessor seems to suffer from same issue. You need to check them all. Further more class property in pur must be string, not class otherwise m2b chant pick it up. |
| Comment by Roman Kovařík [ 24/Jun/13 ] |
Is it possible to do it via UserManager? Currently they are set to empty String.
This was already implemented.
|
| Comment by Roman Kovařík [ 28/Jun/13 ] |
|
Autopopulating with user properties was removed due to security reasons. |
| Comment by Jan Haderka [ 09/Jul/13 ] |
|
just wondering if we could go a middle ground here. Not to automatically populate everything, but allow dev/admin to configure list of fields that would be populated if present. WDYT? |
| Comment by Roman Kovařík [ 16/Jul/13 ] |
|
Allow to specify user profile properties which will be automatically populated. |
| Comment by Jan Haderka [ 24/Jul/13 ] |
|
| Comment by Milan Divilek [ 30/Jul/13 ] |
|
Reopen: extraUserProperties was not change to autopopulatedProperties in /magnolia-module-public-user-registration/src/main/resources/mgnl-bootstrap/public-user-registration/config.modules.public-user-registration.config.xml -> so after installation you get wrong configuration |