Implement the new Resources app (MGNLRES-140)

[MGNLRES-151] Create isEditable column for the resources browser Created: 21/May/15  Updated: 30/Jun/15  Resolved: 29/May/15

Status: Closed
Project: Magnolia Resources Module
Component/s: app
Affects Version/s: None
Fix Version/s: 2.4

Type: Sub-task Priority: Major
Reporter: Ilgun Ilgun Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: platform-cell
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-6237 Add #isEditable to ResourcePath inter... Closed
Template:
Date of First Response:
Sprint: 5.4 Sprint 4
Team: Nucleus

 Description   

Add the editable column for new resources app,

See the hotfix column in mockups at http://wiki.magnolia-cms.com/display/UX/The+Resource+Files+app



 Comments   
Comment by Magnolia International [ 28/May/15 ]

Ilgün, I looked at the commit on main couple things

  • since we're actually changing core in magnolia_main/magnolia-resource-loader, we're gonna need a ticket in MAGNOLIA
  • the "editable" property could be exposed on the ResourcePath interface; LRP could either delegate to first() or (depending on what we want to do) iterate on layers() until one is editable()
  • I'm not sure what we try to do with isOverriding() – at first sight, if size>1, something is overriding something else In any case, we definitely can't rely on the origin names to do things like this. While it's not on the table at the moment, the API was thought out to allow users to customize the list and amount of origins. (e.g info.magnolia.resourceloader.Origins should not be as hardcoded as it is)
  • tests: have you seen DummyOrigin ? It's tested and used extensively in LayeredOriginTest (in fact it was implemented first to allow testing LO without depending on the real origins). I'm suspecting you had to re-implement your own fakes to satisfy the need of your fix (i.e have the origin's names as expected).

As a side note, maybe a few words about intentions in the issue description would be beneficial (esp since this issue might be forked off MGNLRES-140 since it looks like it'll be released sooner)

Cheers !

Comment by Ilgun Ilgun [ 29/May/15 ]

Made the necessary changes regarding review.
Should be good to go now.

Comment by Aleksandr Pchelintcev [ 01/Jun/15 ]
  • FileType needs JavaDoc.
  • Introduced property ids should become constants.
  • Ideally changes related to magnolia_main should be commited against MAGNOLIA-6237 (then current ticket could simply depend on that one).
  • Please remove the commented lines in ResourcesContainer#newItem()
  • Also properties should be clarified:
    • I can understand addition of a nested property (originName) and
    • Should ResourcesContainer#isOverriding be static?
    • editable - if such method is present in ResoucePath API - you shouldn't try to add it explicitly - the property will exist out of the box.
Comment by Ilgun Ilgun [ 02/Jun/15 ]

Everything is done, except the static methods, they are simply because the main method is static as well.

Comment by Mikaël Geljić [ 02/Jun/15 ]

Kept this ticket only for the "editable" column, moved all the rest to MGNLRES-163

Generated at Mon Feb 12 06:47:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.