Implement the new Resources app (MGNLRES-140)

[MGNLRES-153] Create Hotfix action Created: 26/May/15  Updated: 29/Mar/22  Resolved: 05/Jun/15

Status: Closed
Project: Magnolia Resources Module
Component/s: app
Affects Version/s: None
Fix Version/s: 2.4

Type: Sub-task Priority: Major
Reporter: Ilgun Ilgun Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: platform-cell
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Date of First Response:
Sprint: 5.4 Sprint 4
Team: Nucleus

 Description   

Add hotfix action and functionality to the new resource app.



 Comments   
Comment by Aleksandr Pchelintcev [ 01/Jun/15 ]
  • Please merge w/ the latest resource app dev branch (feature/resources-app-3 ?)
    • There are some API changes that need to be fixed, JavaDoc improved etc
  • ResourceContainer uses Apache Tika, but I don't see a dependency in pom file.
  • HotfixResourceAction - JavaDoc could be improved:
  • Smth like "Action for starting a resource hot-fixing within a detail sub-app" + maybe some explanation of what all that means (i.e. about importing to JCR etc).
  • Check the years in your file header template - for the new files there should be 2015 only (I see 2012-2015).
Comment by Ilgun Ilgun [ 02/Jun/15 ]

Everything is covered except:
Apache Tika, comes from the jackrabbit jar. We can explicitly add it to pom if you wish.

Comment by Aleksandr Pchelintcev [ 05/Jun/15 ]

We certainly should - as far as I see (from mvn dependency:tree) Jackrabbit only uses it as a provided dependency whereas we need it in the compiled scope as we use it in production code.

Locally I have compilations issues because of that in IDE (even though being able to build it in command line).

Comment by Aleksandr Pchelintcev [ 05/Jun/15 ]
  • HotfixResourceActionTest#tearDown isn't needed super-method would take of that (and even more)
  • Setting up ctx in setUp() is also redundant.
  • Tika dependency is needed.
  • HotfixResourceActionTest#canHotfixResource
    • assertThat(root.getNodes().getSize(), is(nodeCountBefore + 1)) is a bit misleading - in reality more than just one node is created, please either add a comment what this verifies or just remove it.
  • Maybe I'm just not a fan of a word hotfix, but "Action for creating hotfix in resources detail sub-app." still doesn't explain the action purpose enough imo, I can't understand exactly what happens without going into code details:
    • First of all, the detail sub app is mentioned in JavaDoc but not in the code.
    • Would be nice to elaborate what a hotfix is - that the nodes are created, folders respected (their node types etc).
    • Shouldn't the action actually take us to that detail sub-app so we start to work with the resource without additional clicks and search?
  • message keys used in the code still reference 'resources24' whereas bundles have just 'resources' configured
Comment by Mikaël Geljić [ 05/Jun/15 ]

Doesn't the Tika thingie belong to MGNLRES-163?

By the way, when discussing it with Greg, we're actually not gonna use it, but rather configured mappings via MIMEMapping (if time allows!).

Comment by Ilgun Ilgun [ 05/Jun/15 ]

Made the necessary changes regarding review.

Generated at Mon Feb 12 06:47:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.