[MGNLRES-186] Add create and delete actions for resources Created: 06/Aug/15  Updated: 29/Mar/22  Resolved: 18/Sep/15

Status: Closed
Project: Magnolia Resources Module
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4.2

Type: Story Priority: Neutral
Reporter: Andreas Weder Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: ux
Remaining Estimate: 0d
Time Spent: 4d 4.75h
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2015-09-07 at 14.10.28.png     Text File stacktrace.txt    
Issue Links:
dependency
depends upon MGNLUI-3562 After deleting an content app item ta... Closed
depends upon MGNLUI-3528 BrowserPresenter deletedItem handling... Closed
depends upon MGNLUI-3576 Provide validatable callback action f... Closed
relation
is related to MGNLRES-205 Add Publish Deletion and Restore acti... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Testcase included:
Yes
Date of First Response:
Epic Link: Phase out in-place templating app
Sprint: Basel 12
Story Points: 3
Team: Nucleus

 Description   

We'd like to be able to both remove a JCR resource as well as add a new JCR resource. In addition, the existing "remove hotfix" action has to go away. More details on what these add and delete actions can do and when they should be available can be found here: https://wiki.magnolia-cms.com/display/UX/The+Resource+Files+app#TheResourcefilesapp-Availableactionswhenselectingaresourcefile

Note: the UI design mockups use the Trash icon for the delete action. Please use the "x" icon we're currently using for now - replacing all "x"s with the Trash icon as well as unifying the usage of the "x" in all remaining cases is a future change.

Acceptance criteria

  • "add resource" adds a new resource with either the root item or a selected folder as parent
  • "delete resource" replaces remove hot-fix action
  • "delete resource" removes the selected JCR resource file and asks for confirmation before doing so.
  • updated documentation


 Comments   
Comment by Ilgun Ilgun [ 21/Aug/15 ]

Changes can be found at feature/create-delete-actions/MGNLRES-186

Comment by Federico Grilli [ 15/Sep/15 ]

Can't remove a resource having a binary sub-node (that of type mgnl:resource). The check at info.magnolia.resources.app.action.DeleteResourceAction.removeNodeAndEmptyAncestorsFromJcr(Node) line #123 would return true and node deletion be skipped.

Comment by Ilgun Ilgun [ 21/Sep/15 ]

Found a small issue with the DeleteResourceAction where one tries to delete multiple resources.

FIxed the issue and pushed it to fix/MGNLRES-186-updated-add-resource-dialog. Please do not forget to squash the commit before integrating.

Comment by Mikaël Geljić [ 29/Sep/15 ]

Fixed those while doing QA:

  • one missing bootstrap update to EditorCallbackActionDefinition
  • bumped UI dependency to 5.4.3 (implicit but used in new bootstraps)
  • tentatively clarify i18n keys via conventional tab naming

I also went ahead with few polishing changes w/ Andreas:

  • polished labels for add & upload dialogs
  • made upload dialog "strong" (circumventing layout issue, aligning with other apps)
  • removed notifications when adding/uploading resources
Generated at Mon Feb 12 06:48:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.