[MGNLRES-188] Show the activation status of JCR resource files Created: 06/Aug/15  Updated: 29/Mar/22  Resolved: 26/Aug/15

Status: Closed
Project: Magnolia Resources Module
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4.2

Type: Story Priority: Neutral
Reporter: Andreas Weder Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1d 5h
Original Estimate: Not Specified

Attachments: PNG File QA-unpublished-folders.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Phase out in-place templating app
Sprint: Sprint 7 (Basel)
Story Points: 3
Team: Nucleus

 Description   

We currently don't show the activation status for JCR resources, but should so. For all resource files from other origins or folders, please don't show anything.

Contrary to what is shown in the mockups, please only show the red/yellow/green circles we show in all other apps. We do have icon versions that offer the distinct shapes for published/changed/unpublished shown in the mockups, but for consistency reasons, I'd like to show the same full-circle shape only here.

Acceptance criteria

  • Status column added, shows activation state for JCR resource files (only)
  • nothing shown in that column items other than JCR resource files.
  • full circle shape only used for status icons


 Comments   
Comment by Ilgun Ilgun [ 18/Aug/15 ]

Changes can be found in feature/activation-status/MGNLRES-188

Comment by Aleksandr Pchelintcev [ 20/Aug/15 ]

1) ResourcesStatusColumnFormatter
– no need to do the JCR-item related work - item id is already a resource path.
– pls add a unit test, that is easy
2) pom change - UI dep version increased to 5.4.1 - is it really needed?
3) ResourcesStatusColumnDefinition seems like the following is just copied from the parent class (??):

    // Show Activation Status
    private boolean activation = true;

    // Show Permission Status
    private boolean permissions = true;

    public boolean isActivation() {
        return activation;
    }

    public void setActivation(boolean activation) {
        this.activation = activation;
    }

    public boolean isPermissions() {
        return permissions;
    }

    public void setPermissions(boolean permissions) {
        this.permissions = permissions;
    }
 

4) Transaltions:

  • 'resources.browser.views.treeview.activationStatus.label=Status' is in incorrect block ('actions') and could be expressed shorter (pls take a look at the analogous column label defs in e.g. admincentral).
    5) bootstrap file also could lose the activation status properties
Comment by Ilgun Ilgun [ 20/Aug/15 ]

Made the necessary changes and pushed to the same branch.

Comment by Aleksandr Pchelintcev [ 21/Aug/15 ]
  • MVH task's missing
Comment by Federico Grilli [ 24/Aug/15 ]

QA reopen: After editing a resource found e.g. on the cp the resource file itself AND the folder hierarchy containing it shows an unpublished status too (so far so good, I think). Problem is reverting the hot fix leaves the folder status as unpublished, whereas nothing should be displayed. See also screenshot

Comment by Aleksandr Pchelintcev [ 26/Aug/15 ]

A minor but important thing I overlooked during my own review at first - the latest MVH clause has version 2.4.1, whereas the current version of resources app is 2.4.2.

Generated at Mon Feb 12 06:48:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.