[MGNLRES-28] Counts for all modules: getRepository() in module class should be static for use in update tasks. Created: 05/Nov/10  Updated: 29/Mar/22  Resolved: 02/Dec/13

Status: Closed
Project: Magnolia Resources Module
Component/s: management
Affects Version/s: 1.3.1
Fix Version/s: None

Type: Improvement Priority: Minor
Reporter: Christian Ringele Assignee: Roman Kovařík
Resolution: Obsolete Votes: 0
Labels: quickwin
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Team: Nucleus

 Description   

On state of update, the module classes are not instantiated yet.
So ModuleClass.getInstance().getRepository() can't be called.

Should be possible to use the repo name dynamically in the update tasks too, and not hard coded:
ModuleClass.getRepository()

This counts for many modules, which provide the name of their repository.



 Comments   
Comment by Magnolia International [ 23/Dec/10 ]

What difference does it make ? If it's a static method, the repository name will be hardcoded too, just in a different place.
Is there a place in this module where ModuleClass.getInstance().getRepository() is used ?

Comment by Roman Kovařík [ 02/Dec/13 ]

The constant ResourcesModule.DEFAULT_WORKSPACE already exists.

Generated at Mon Feb 12 06:46:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.