[MGNLRES-341] Resources-app, deleting items w/ various issues Created: 22/Nov/19  Updated: 29/Mar/22  Resolved: 21/Feb/20

Status: Closed
Project: Magnolia Resources Module
Component/s: None
Affects Version/s: 3.0
Fix Version/s: 3.0

Type: Bug Priority: Neutral
Reporter: Christoph Meier Assignee: Adam Siska
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 1h
Time Spent: 0.3h
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLUI-5286 DOC: Update Resource Files app page f... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Documentation update required:
Yes
Date of First Response:
Sprint: UI Framework 16, UI Framework 17
Story Points: 3
Team: Nucleus

 Description   

 Wait with this one until we see what PAGES-219 (Actions availability "out of sync") can resolve.

 


The M.-6-UI version of the Resources app has various issues when it comes to deleting items.

Publish "marked as deleted" items is not working

It just doesn't work, without throwing an exception, there is nothing visible in the log.
Final deletion is not possible with this app.

Related to this: Currently our head of UX avongunten checks whether it was "valid" to remove the old Publish deletion action (with the idea to utilize the Publish action) in the new Assest-app ... so ... there is a "chance" that you have to bring back the "old action".

Bring back the action "Publish deletion"

As far as I  have understood UX / Anja - the ported apps should have the same actions as the "old" apps.
Hence we should provide the action "Publish deletion".

Deleting an item throws an exception (silently)

Deleting works - leading to an item with the "trash bin" icon (marked for deletion), but an exception is thrown every time.
Sometimes (or always?) it is java.lang.IndexOutOfBoundsException.
Sometimes I also see this one:

WARN  org.apache.jackrabbit.core.SessionImpl            : Unclosed session detected.

Icons of parent items with wrong status (showing trash bin) / maybe restoring issue

When deleting an item, its parent folder(s) also change into the "marked for deletion" status icon (the trash bin) ... for some cases.
That is legit, if all the parent folders are just JCR based resource representations of folders.
If the parent folders are files (from light-modules), that should not happen, otherwise it would frighten the user (if I would be the user).
I have not yet fully understood when this happens. 

Update:
Publishing the nodes which are marked for deletion in fact works, but throws an exception, which make it look like it failed.
When publishing the deletion of /mtk/templates/pages/basic.yaml - all parent folders are deleted, besides the "super parent/ /mtk.
Earlier versions have been deleted all parent folders (when there was no ,ore other hotfix in its path).

example-1: Add a resource within mte, then delete the resource. mte then also gets the trash-bin icon.
Especually bad: When restoring the resource, the restored resource gets the normal, correct icon, but the parent folder keeps the trash-bin.
That's wrong for sure.

example-2 Have a light module. Then ad a resource via resource app. Delete it, and restore it. All fine.

Little UX glitch

The "title" (html attribute) displaying the origin of a file shows always "JCR". That's wrong in some case.



 Comments   
Comment by Anja von Gunten [ 12/Dec/19 ]

cmeier (cc slutz rkovarik)

If you consider changing basic UI patterns such as "deleting items"

  • it has to be not only technically better than the old version but also for the user, please take me in the loop to validate (e.g. for a new user it's not obvious that a deleted item has to be published, "Publish deletion" in that case is better)
  • it has to be changed for all apps, we have to avoid using different patterns in different apps > very confusing for users
  • it requires updating documentation (and maybe other communication channels?)

Therefore at this stage i would vote to use the old pattern "Publish deletion" as we had it, just to minimize change efforts at this point of time

 

Comment by Adam Siska [ 24/Feb/20 ]

Clicked on 'Documentation update required' because we have still only old app documented: https://documentation.magnolia-cms.com/display/DOCS62/Resource+Files+app

Generated at Mon Feb 12 06:49:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.