Text files stored incorrectly as binary (MGNLRES-346)

[MGNLRES-349] Improvement AddResourceAction and ResourcePropertySetFactory Created: 11/Mar/20  Updated: 29/Mar/22  Resolved: 16/Mar/20

Status: Closed
Project: Magnolia Resources Module
Component/s: None
Affects Version/s: 3.0
Fix Version/s: 3.0

Type: Sub-task Priority: Neutral
Reporter: Rishab Dhar Assignee: Rishab Dhar
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Sprint: UI Framework 18, UI Framework 19
Team: Nucleus

 Description   

The implementation for adding File, adding Folder, and uploading a File is currently split between ResourcePropertySetFactory and AddResourceAction, with a lot redundant code in ResourcePropertySetFactory related to static properties and hidden complexity in info.magnolia.resources.app.data.ResourcePropertySetFactory.Definition#getSetter. This functionality should be extracted out and handled in AddResourceAction to simplify the implementation.



 Comments   
Comment by Rishab Dhar [ 16/Mar/20 ]
  • Split the functionality between info.magnolia.resources.app.action.AddResourceAction which is used for creating resources from form dialogs and info.magnolia.resources.app.action.UploadResourceAction which is used for creating resources by uploading them.
  • The info.magnolia.resources.app.data.ResourcePropertySetFactory.Definition#getSetter returns an empty lambda.
  • Static properties reduced to CONTENT and NAME with new properties configured added on the fly.
Generated at Mon Feb 12 06:49:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.