[MGNLRES-42] Issues with InstallResourcesTask and InstallResourceTask Created: 08/Mar/12 Updated: 29/Mar/22 Resolved: 20/Dec/13 |
|
| Status: | Closed |
| Project: | Magnolia Resources Module |
| Component/s: | management |
| Affects Version/s: | 1.5, 2.0.1 |
| Fix Version/s: | 2.2.1 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | maintenance | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Team: | |||||||||||||||||
| Description |
|
The 1.5 release of the resources module introduced two things
Following those changes, I have a couple of issues with InstallResourcesTask and InstallResourceTask
In fact, if the module comes with predefined templates for css, js, binaries, and nothing else, it might even be a good idea to use static factory methods as suggested above, with explicit method names for each kind of resource we want to support, instead of relying on a file's extension ? |
| Comments |
| Comment by Magnolia International [ 08/Mar/12 ] |
|
As a side note, it might also be judicious to check/improve the Javadoc for InstallReferenceResourceTask. I have no idea what that is for. |
| Comment by Jan Haderka [ 04/Dec/13 ] |
|
Please squeeze all those commits in one before merging. |
| Comment by Roman Kovařík [ 20/Dec/13 ] |
|
InstallBinaryResourceTaskTest fails on mac. |
| Comment by Mikaël Geljić [ 20/Dec/13 ] |
|
see additional QAs: https://git.magnolia-cms.com/gitweb/?p=modules/resources.git;a=commit;h=d6f7423a096b0d77d23574339e3d5c910f711788 |