[MGNLRES-48] Bypassing resources not working Created: 27/Jan/12  Updated: 29/Mar/22  Resolved: 30/Apr/12

Status: Closed
Project: Magnolia Resources Module
Component/s: None
Affects Version/s: 1.4.1, 1.5.2
Fix Version/s: 1.4.2, 1.5.3

Type: Bug Priority: Major
Reporter: Milan Divilek Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Team: Nucleus

 Description   

Resources (CSS, JS) are served from repository (instead of the file system) no matter what the state of the "Bypass" checkbox for that resource is, when it's use resource type "Javascript" or "CSS". For resource type "Processed javascript" or "Processed CSS" bypassing works fine.



 Comments   
Comment by Jan Haderka [ 26/Apr/12 ]

Exception handling is not correct. First you throw FileNotFound just to catch it few lines later as IOException and rethrow it as RenderException.
Also it should be possible to not create string buffer unnecessarily.
Last but not least why is test not ported together w/ fix?

Comment by Milan Divilek [ 30/Apr/12 ]

Last but not least why is test not ported together w/ fix?

Test isn't ported because test class info.magnolia.module.resources.renderers.ResourcesTextTemplateRendererTest is written for mockito so it isn't easy to port.

Comment by Nils Breunese [ 11/Oct/12 ]

After upgrading from Magnolia 4.4.6 with Resources module 1.4 to Magnolia 4.4.9-jr24 with Resources module 1.4.2 bypassing CSS and JavaScript no longer works. However, this issue says the problem was fixed in 1.4.2?

Generated at Mon Feb 12 06:46:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.