[MGNLRES-97] InstallBinaryResourceTask shouldn't use deprecated API Created: 31/Jan/14  Updated: 29/Mar/22  Resolved: 14/Feb/14

Status: Closed
Project: Magnolia Resources Module
Component/s: None
Affects Version/s: 2.2.1
Fix Version/s: 2.2.3

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Team: Nucleus

 Description   
  1. javax.jcr.Node.setProperty(String, InputStream) shouldn't be used
  2. InstallBinaryResourceTaskTest is wrong and should be fixed
  3. src/test/resources/templating-kit/img/magnolia-logoTest.gif is actually png


 Comments   
Comment by Magnolia International [ 31/Jan/14 ]

Don't do new org.apache.jackrabbit.value.BinaryImpl() - you need to get the "correct" Binary impl through the session/valuefactory (i think)
Alternatively, we could look into using org.apache.jackrabbit.commons.JcrUtils#putFile (jcr-commons are meant to be repository-agnostic)

Comment by Mikaël Geljić [ 15/Feb/14 ]

Now this test works like a charm on my machine
Only (unrelated) remaining failure at testDifferentPlatformEncoding(info.magnolia.module.resources.setup.InstallResourceTaskTest)

Generated at Mon Feb 12 06:47:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.